Received-SPF: pass (google.com: domain of linux-crypto+bounces-4507-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e0293a49-3609-a83a-f129-97ead8467057@amd.com>
Date: Wed, 29 May 2024 11:50:24 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v2 2/5] crypto: ccp: Move security attributes to their own
 file
Content-Language: en-US
To: Mario Limonciello <mario.limonciello@amd.com>,
 Herbert Xu <herbert@gondor.apana.org.au>
Cc: "open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER - DB..."
 <linux-crypto@vger.kernel.org>, Richard Hughes <hughsient@gmail.com>,
 open list <linux-kernel@vger.kernel.org>
References: <20240528210712.1268-1-mario.limonciello@amd.com>
 <20240528210712.1268-3-mario.limonciello@amd.com>
 <7f9db4de-635f-6204-d261-3bcd0aac1c25@amd.com>
 <e29a975a-cb63-43cb-a421-8d7dd5ca36a6@amd.com>
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <e29a975a-cb63-43cb-a421-8d7dd5ca36a6@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RmxOZGlhTCtpYjl4SDZ4c1hoQXVzcnVvUW9nRkFaZUlNY0tkdksrKy96bi9p?=
 =?utf-8?B?Mm9USDFzQ09qTFpZWlorTngyazlianhZKzM0dGRINFJjYzVwcnVacFJ4NU1v?=
 =?utf-8?B?aUN4eXRyNk02MUwyZUFwZGoyU2ZVcm5UbjdJaVBYUFZJakp0U3k2UVBvM0VF?=
 =?utf-8?B?VWdIeG9qVDU1WTVOb0dPU0N4cDBOTUhrcXdxd0ozK21OMEw5ZVJUdUhLK1M2?=
 =?utf-8?B?WXlyUndFUHJyc29xdzJPbUs1S3VENE45WVZpSU9DNGk5dzdZTXN1Umk3K0R1?=
 =?utf-8?B?eEZNZXNYNHQ2TEkzSWpoQWtPWGdQNnFBYVlURkhxY2hud1g1dktOdGR4U0Jw?=
 =?utf-8?B?ZGZOM2tZblFqYTJqMUNKdVNjZ0M0WkR2QjlCOU1TWFpFYjZXZUZZUG1ncGZR?=
 =?utf-8?B?U0NObkR0SmdPVlg1REplK2g4YkF4TzhDT2ZEbDY4eXNCYUw0b1Z2MnJzK1h5?=
 =?utf-8?B?VHV1Tm5Wb0ZFQXFoNW9adm1wYnV3MUNmYnF5SGFia1lIeEZudlN5MDJRS3kx?=
 =?utf-8?B?bGZYTHhvblZGUTRLcW9Za3RnaENtVGtaeTVnKzU1VE9xWFkrMGZmVHBmcGtu?=
 =?utf-8?B?cTJFSEhQWEIrTkdzdkpuOXBzYkxmdEd1dlZmNk9yb1NESVVDdVIrd3NBRkgy?=
 =?utf-8?B?NzdsejdtRWRwTk4vWnNDMldGQmloWkViaFYycGdndHBUNU1GY2Nqb3BaOThS?=
 =?utf-8?B?NSszcWhYbEZ6U3VVcGkrVVh0cWlhS2RoQkdNZGNXTmR4NGZBdGl5TmxyQXoz?=
 =?utf-8?B?NGZKYjNLUzZ1Z3N0d0tFcmF2TGlvNXRrVjFKRVFJcDV3UFlDUSttanZxVXBM?=
 =?utf-8?B?aWZ5U0draUlrT1dRajVHdTFpYVJXZ0NUV2FjVVRsY1VOdTNqM3V5TGdGRDBW?=
 =?utf-8?B?eDZBVXlWNldYcGRzWXliY3RlT2FYdnFMQ0ZXZENMTTFrMmVwaVp3a1pjQXBT?=
 =?utf-8?B?Wnp1ZldDWFo0bW1LYTAwU2drUktRSFI3Wjc1WElxUUFrZHNhdUNXRnptYWd6?=
 =?utf-8?B?SGtPSm5sSXpXV2lXZW8yeHltUUUzNUFXTnV0VEIwbUdleUQvUjVuOUd1VC9X?=
 =?utf-8?B?RTZkb1NuNjVxR0gzQWEyQzlsSnNCaE5lZzlvQkFETVB4aVBMamJJeW16azdu?=
 =?utf-8?B?TVhhbStRaUp1a2Nxbm1GZmdObHNnRy85RjNSeCsyNTJqb0VNZ1hmdmxzRC9T?=
 =?utf-8?B?cXZxVXBSeG94WXg0ZlFvWm1ZeWJrbERaUGZFb1FaL0NQZlB5bjhwVXovWDVR?=
 =?utf-8?B?UzlqazEvV2ppVHd4bC9hTTNNM00zSHo2WjlFNEpDV0QrNHZzQWVLdllHdlNs?=
 =?utf-8?B?NHFnMis1OTBWQU51dm9CYmphRVRNMGxCNEJQV0xVSCtGNW1xU0tJZG5CMFNB?=
 =?utf-8?B?UXNvZmpMSk5oc0Z3Q1dTeVVkNWhVenBtWjJuTGd4Szg0enNURUloSnNtdnBu?=
 =?utf-8?B?VWwyN2pNczRwWmF2N3RDcWM5OXp4dmlFbGIzOXZ3bmZmbjByaU1nOGIzc0p1?=
 =?utf-8?B?ajhSaHpnQmk1ajF6MjA1aXJuanM3bmttb0VPRVVXTFJxaThjTWN0ajNLR3d5?=
 =?utf-8?B?NGR1NjFzenN4N2x2bWorSjBwTzl4YUxwYmMvWTJTWkg1THhOWlVPcU1EdGZx?=
 =?utf-8?B?UWJxMGVnS2pPOEE1bDZWTlFMK3UzaEQ5cVc0QWVSa3JvYXlQVlNhdCt0dzFq?=
 =?utf-8?B?S01lRk15dTJYcFhiYkpSTi9LOEh0eWZZOWliSWpWZGxyK2V4VFhOODJqcDhv?=
 =?utf-8?B?WDVVMWdOVU5WSGkwVUZ2cGVoblJhOGRHWE5nRDNhTlZIRVVPbGFqYzA1QXIw?=
 =?utf-8?B?M3kxNXlOUG9tdUhPWUZDbDNGRGdVbTVVTzl0SENMb1pwak9QYWp0Y2YyTVNm?=
 =?utf-8?B?U0V2UXNlcXdVWjJIZUlRaXA5Wmt6VytQdnU2UCsyeHEzaXFJT01POEg3ODI0?=
 =?utf-8?B?R2xrKzdxOEZlU0lmWFNkSWpOSVprRlB3NVM5TDNiaDlGek91b3lNLzQxSVBE?=
 =?utf-8?B?cXdkVHd2RFMvbmh1RzdHS056c2Mzbkk5elJXaFFRK0o1RlhRdXRTaUtOa0h0?=
 =?utf-8?B?L3JyZG9rMXRqS1lhNDJFNG9RSi93OEg2WDV1QWN6bTY3SExnWFVDUVQwbGFJ?=
 =?utf-8?Q?IATTAdf5vklHoECikBAwK4zGB?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f500747-acf1-4d14-2a17-08dc7fff70e8
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 16:50:26.8820
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BRWtMipMP/uZzfwigcwoswYIeOPNbIEI0nWvl8Kp/ZmTaSz2hM3HUrIqF0vZwwPaTlJVZlyrDh8YPlQwQ2DSkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8196

On 5/29/24 11:22, Mario Limonciello wrote:
> On 5/29/2024 10:20, Tom Lendacky wrote:
>> On 5/28/24 16:07, Mario Limonciello wrote:
>>> To prepare for other code that will manipulate security attributes
>>> move the handling code out of sp-pci.c. No intended functional changes.
>>>
>>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>>> ---
>>> v1->v2:
>>>   * Only add psp_security_attr_group when PSP support enabled
>>>     (Fixes lkp robot reported Kconfig issue)
>>
>> Just verifying that there's no change in behavior in regards to 
>> whether the attributes are shown. Previously the attributes were not 
>> shown if CONFIG_CRYPTO_DEV_SP_PSP was "n" because the psp value would 
>> be NULL in psp_security_is_visible(), right?
> 
> Yes; that's right.

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

>