Received-SPF: pass (google.com: domain of linux-crypto+bounces-4517-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 30 May 2024 08:28:43 +0300
Message-Id: <D1MQC3CFQVE0.W19B0918DT1I@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <lukas@wunner.de>
Subject: Re: [PATCH 2/2] crypto: ecdsa - Use ecc_digits_from_bytes to
 convert signature
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Stefan Berger" <stefanb@linux.ibm.com>, <keyrings@vger.kernel.org>,
 <linux-crypto@vger.kernel.org>, <herbert@gondor.apana.org.au>,
 <davem@davemloft.net>
References: <20240529230827.379111-1-stefanb@linux.ibm.com>
 <20240529230827.379111-3-stefanb@linux.ibm.com>
In-Reply-To: <20240529230827.379111-3-stefanb@linux.ibm.com>

On Thu May 30, 2024 at 2:08 AM EEST, Stefan Berger wrote:
> Since ecc_digits_from_bytes will provide zeros when an insufficient numbe=
r
> of bytes are passed in the input byte array, use it to convert the r and =
s
> components of the signature to digits directly from the input byte
> array. This avoids going through an intermediate byte array that has the
> first few bytes filled with zeros.
>
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> ---
>  crypto/ecdsa.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/crypto/ecdsa.c b/crypto/ecdsa.c
> index fa029f36110b..941cdc2b889b 100644
> --- a/crypto/ecdsa.c
> +++ b/crypto/ecdsa.c
> @@ -38,7 +38,6 @@ static int ecdsa_get_signature_rs(u64 *dest, size_t hdr=
len, unsigned char tag,
>  	size_t bufsize =3D ndigits * sizeof(u64);
>  	ssize_t diff =3D vlen - bufsize;
>  	const char *d =3D value;
> -	u8 rs[ECC_MAX_BYTES];
> =20
>  	if (!value || !vlen)
>  		return -EINVAL;
> @@ -46,7 +45,7 @@ static int ecdsa_get_signature_rs(u64 *dest, size_t hdr=
len, unsigned char tag,
>  	/* diff =3D 0: 'value' has exacly the right size
>  	 * diff > 0: 'value' has too many bytes; one leading zero is allowed th=
at
>  	 *           makes the value a positive integer; error on more
> -	 * diff < 0: 'value' is missing leading zeros, which we add
> +	 * diff < 0: 'value' is missing leading zeros
>  	 */
>  	if (diff > 0) {
>  		/* skip over leading zeros that make 'value' a positive int */
> @@ -61,14 +60,7 @@ static int ecdsa_get_signature_rs(u64 *dest, size_t hd=
rlen, unsigned char tag,
>  	if (-diff >=3D bufsize)
>  		return -EINVAL;
> =20
> -	if (diff) {
> -		/* leading zeros not given in 'value' */
> -		memset(rs, 0, -diff);
> -	}
> -
> -	memcpy(&rs[-diff], d, vlen);
> -
> -	ecc_swap_digits((u64 *)rs, dest, ndigits);
> +	ecc_digits_from_bytes(d, vlen, dest, ndigits);
> =20
>  	return 0;
>  }

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko