Received-SPF: pass (google.com: domain of linux-crypto+bounces-4521-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Content-Type: multipart/signed;
 boundary=432b71ef613f91233681e8ff6b308ab1f6a32c4fb336c68c48fb0ae1b4d1;
 micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk
Mime-Version: 1.0
Date: Thu, 30 May 2024 12:30:48 +0200
Message-Id: <D1MWRDJ06QSQ.5HMWERLERPLY@gmail.com>
To: "Akhil R" <akhilrajeev@nvidia.com>, "Christophe JAILLET"
 <christophe.jaillet@wanadoo.fr>, "Herbert Xu"
 <herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>,
 "Jon Hunter" <jonathanh@nvidia.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
 "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
 "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] crypto: tegra - Remove an incorrect iommu_fwspec_free()
 call in tegra_se_remove()
From: "Thierry Reding" <thierry.reding@gmail.com>
References: <ea775b351a3dbe4cef4056ea89da25084f73df22.1716650050.git.christophe.jaillet@wanadoo.fr> <SJ1PR12MB633943D654272A0612695F1DC0F22@SJ1PR12MB6339.namprd12.prod.outlook.com>
In-Reply-To: <SJ1PR12MB633943D654272A0612695F1DC0F22@SJ1PR12MB6339.namprd12.prod.outlook.com>

--432b71ef613f91233681e8ff6b308ab1f6a32c4fb336c68c48fb0ae1b4d1
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Wed May 29, 2024 at 8:53 AM CEST, Akhil R wrote:
> > The only iommu function call in this driver is a
> > tegra_dev_iommu_get_stream_id() which does not allocate anything and do=
es
> > not take any reference.
> >=20
> > More-over, what is freed is "se->dev" which has been devm_kzalloc()'ed =
in the
> > probe.
>
> I did not completely understand what is being tried to convey here.
> If I understand it right, iommu_fwspec_free() does not do anything
> with the "devm_kzalloc"ed variable.=20
>
> It would probably be a good idea to remove this line from the commit mess=
age.

Yeah, I think that's a bit misleading. What iommu_fwspec_free() does is
get the iommu_fwspec from the passed-in device and then frees that
iommu_fwspec.

That said, as I was looking around I didn't spot anything that was
calling iommu_fwspec_free() in any of the cleanup paths, so either I'm
missing something or it's a real memory leak (though perhaps one that we
are ignoring on purpose because these are usually attached to devices
that don't just go away).

Thierry

--432b71ef613f91233681e8ff6b308ab1f6a32c4fb336c68c48fb0ae1b4d1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmZYVVgACgkQ3SOs138+
s6E2HxAAuli1khZJ9nZCFGOj9+lAW2lbumnnvQ85exAHuhwyA6rr/bsLI5sQbQ/K
Km/xVh28quZkpsmwx+q1LmLrHg9FVbX18QvRtZc7qQeWcV32dTJXOZ4KnAQJdQGL
Jn7mlbh850HJrGZsFv529irOZupkSF1fwJl4rb4iEMdlZPIgC/LjSzSrZ/MZkfLN
dQChxDuNs/d7CXIASvzamq6pZiHJ4iNG1e1fqZZw3Nl10gGKwFWYeEjryYrY6hsx
Niw+oP7cicqmfciR+eQQ67KZj8o0J0c1JcxXCeXSBhxbSakVrcXqNAYNFEGhvtXu
1Slk/zgjmbrXdd1jgx+U0+95GjcCDq9DABmKVsv3ilzrMqDWAL8jVHhtI9rqbPA1
IxUgAqhNkadrb7wPqHrlqu8c3qwRupvMnCT5Eda6Nxr6BFwfNqnsj42zTDIIBoVl
ammjk4uxt0HEqrHzrueowXN/rrgNKVIZQjbBKVglE78WidJbGON3MfT5W68wO0Vv
TRzajZn9fhs6TUc6/AKqgmIeD1CeuNEmCWUGtsZm6JuNh71OQNVS9/5BYEFOC8oJ
M2/knQPUleCk6GKhsSIGVd2bRfzWZJsWPciTSLJoMI4jb0hSh7xlKYI8bYDD0j0R
bCkE4jndIqvW/GT82ewQ0mU+4d8t1pBvPrIIubrxKiZdSnSwDZI=
=DssT
-----END PGP SIGNATURE-----

--432b71ef613f91233681e8ff6b308ab1f6a32c4fb336c68c48fb0ae1b4d1--