Received-SPF: pass (google.com: domain of linux-crypto+bounces-4576-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Akhil R <akhilrajeev@nvidia.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
CC: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, "David S. Miller"
	<davem@davemloft.net>, Thierry Reding <thierry.reding@gmail.com>, Jon Hunter
	<jonathanh@nvidia.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>, "linux-crypto@vger.kernel.org"
	<linux-crypto@vger.kernel.org>, "linux-tegra@vger.kernel.org"
	<linux-tegra@vger.kernel.org>
Subject: RE: [PATCH] crypto: tegra - Remove an incorrect iommu_fwspec_free()
 call in tegra_se_remove()
Thread-Topic: [PATCH] crypto: tegra - Remove an incorrect iommu_fwspec_free()
 call in tegra_se_remove()
Thread-Index: AQHarrZLeawWiYOujkiA3zLjv6FXT7GtyrXAgAMNKACAAAGJYA==
Date: Fri, 31 May 2024 05:36:48 +0000
Message-ID:
 <SJ1PR12MB633958B0DC8504F1D7868CA0C0FC2@SJ1PR12MB6339.namprd12.prod.outlook.com>
References:
 <ea775b351a3dbe4cef4056ea89da25084f73df22.1716650050.git.christophe.jaillet@wanadoo.fr>
 <SJ1PR12MB633943D654272A0612695F1DC0F22@SJ1PR12MB6339.namprd12.prod.outlook.com>
 <Zllexnetg3eu6dSW@gondor.apana.org.au>
In-Reply-To: <Zllexnetg3eu6dSW@gondor.apana.org.au>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?AtoKt8aWeSEsYnEQoC0/9RYObs5ZYrBkMilw/iTOdapaqfIjJyGecOmwHQtC?=
 =?us-ascii?Q?K6/tjsfs52Hwc/JGGz+GPaZdsm3ph1o+ZFMV7RYM4T9JfZGy4ecA4CG50Iqe?=
 =?us-ascii?Q?DR8cv2e7DQdYywFPIIU/q8J9WBPOEZHGpL4y6n7S0COJyNn+JuuUrcWKYQdf?=
 =?us-ascii?Q?IcIop/WBYfL+4s6UW9yayCLKYfHbh4q3UVuTFq26uvlNSYSfMqVXZNP9OQsp?=
 =?us-ascii?Q?pi1oMDLNLvBDbtRc0FS/PYD+arvoypyQx3Ekor06bts488Xl3xNm30Sy2wq8?=
 =?us-ascii?Q?BXkKq8/Tcm5zxxSvq1BLrMwAfUcU0v4C3k8nWAoChyDSJXxmOhdOcG0s9La4?=
 =?us-ascii?Q?11DWRRrpOllvVbEdDsx/Rz/od2Kgtw8Zzr9KX28RLZgu1ePVyoyF1vYbsY/x?=
 =?us-ascii?Q?hUtUINUy/A3qT6UJ8sc4IOC/ykbhosefv9ONpaGWkl/DSkCZugyh5LHkjdGf?=
 =?us-ascii?Q?2ro354s9nMQlADC/v0igAQ26KTCbQQhR5lED1tzL8B0j0MU5AMu9W1FXaDHh?=
 =?us-ascii?Q?wd9Ahoau/jAEo3JeLonENlP7KYL6gfW8AJpB7myA8EmHPBZCuJ8W8S+oUcb+?=
 =?us-ascii?Q?KNH0qeWrCAqOsAUdmKa4MMu3nnOMahEN7+2EAKehSH2eO4kr+tD/9nnN4T+7?=
 =?us-ascii?Q?cc82w4gjcCOh6Xv+kGpPbPUTOT2Qxvbea7A3pwmGWLIzlDt2QnG9q+Kuf9aq?=
 =?us-ascii?Q?XMUnUENVvqI5W7XjQHqzFfp2S/QeNvXfUjoMjQhTmAEz8RpqgRzmSluq8s7R?=
 =?us-ascii?Q?17SzstEkxLuqIekKe1/tIDVBV60Ms4alOVVw/35XLzB2xTe/JOpiwnRk9CsN?=
 =?us-ascii?Q?Ieyy0Lp2SZaYBv3U6e98d06S3YRuywgxDEX6HWAdl3+mn+knQ41DdNECbYWJ?=
 =?us-ascii?Q?KiLeG3/dfgr9f8VnRUPhYHLHan0t+nEtjj2TIMyCyzOXCsKFwsrBCnJkVJ+1?=
 =?us-ascii?Q?yczRLRcUC0m/dNUpN0kpLVt2E1RV9IQfPS/LJ5ZTIER/CSxrBTZEyjkGzCYI?=
 =?us-ascii?Q?Bkf/1y27xK3o0sL2BXeVq4/TdrPjHdDV/ynsI6febrmTciO0jjmaV09iVMoU?=
 =?us-ascii?Q?Asf5wgE5GLCQZFnyLhRg71boKmlxRTESGOe3ramVIKPVlvOpI23iLm/NcgzR?=
 =?us-ascii?Q?Cn4rSoP6/NWzcKsNfUkkE2WnBf1Zu7o2TJ2JEQDQXJ6e3zMDAgYeU70O+c+G?=
 =?us-ascii?Q?8MTJ1dr6wcup3hwN3rVXN9d5JsZ+QTyOaaCbAzEFvuI1EytCLjRWwyeSHF4z?=
 =?us-ascii?Q?xR2c9JVwsLiAOUNGaeUtF7SacdEpWkNl19vh9gZPoI4zf8nC/a9RyqsqPY7t?=
 =?us-ascii?Q?IDcSAL2oU4xE23rtDsYcx4XoG9JURZWnjq67P4c4HmFDR4ygYO6DyY171xrm?=
 =?us-ascii?Q?gc7/xeYk3Eu+UgzC1adNk/Z2MFQLQ904uuG+PD521wxbxkdiUE9trfQ/qTOB?=
 =?us-ascii?Q?HHoO5GAkhgXIz099xLlOjnHNJTrvj31ugrKE3HxTzFRrHxd9Fgyelh9qAMGL?=
 =?us-ascii?Q?jIWrtRJSfcxfmIVOe9NVVblT3w7MV+OSLv2HTCIND3lhsMvW9aRl7J2gkPHM?=
 =?us-ascii?Q?4nuwd3MsXRfBaLyOXGIrrzIrxXmmXQYysjRa6W5a?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-crypto@vger.kernel.org
List-Id: <linux-crypto.vger.kernel.org>
List-Subscribe: <mailto:linux-crypto+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-crypto+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR12MB6339.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 81ff2466-ffea-49bd-d8b0-08dc8133aa67
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2024 05:36:48.1404
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rPz3aeiOZ90wSiTH2bRX4Cih68LUewMB6q6hSwdpfFpXrIuKjTS05XMmRTIaZyN0qq34z9gR9P6SYZYQNejU3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7922


> -----Original Message-----
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Sent: Friday, May 31, 2024 10:53 AM
> To: Akhil R <akhilrajeev@nvidia.com>
> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>; David S. Miller
> <davem@davemloft.net>; Thierry Reding <thierry.reding@gmail.com>; Jon
> Hunter <jonathanh@nvidia.com>; linux-kernel@vger.kernel.org; kernel-
> janitors@vger.kernel.org; linux-crypto@vger.kernel.org; linux-
> tegra@vger.kernel.org
> Subject: Re: [PATCH] crypto: tegra - Remove an incorrect iommu_fwspec_fre=
e()
> call in tegra_se_remove()
>=20
> External email: Use caution opening links or attachments
>=20
>=20
> On Wed, May 29, 2024 at 06:53:42AM +0000, Akhil R wrote:
> > > The only iommu function call in this driver is a
> > > tegra_dev_iommu_get_stream_id() which does not allocate anything and
> does
> > > not take any reference.
> > >
> > > More-over, what is freed is "se->dev" which has been devm_kzalloc()'e=
d in the
> > > probe.
> >
> > I did not completely understand what is being tried to convey here.
> > If I understand it right, iommu_fwspec_free() does not do anything
> > with the "devm_kzalloc"ed variable.
> >
> > It would probably be a good idea to remove this line from the commit me=
ssage.
>=20
> I think he means that as the memory was allocated via devm, it will
> be automatically freed by the kernel and the driver does not need
> to (and should not) free the memory by hand.

Ya. But iommu_fwspec_free() does not free the memory allocated via devm.

I think iommu_fwspec_free() is expected to be called in symmetry with
iommu_fwspec_init(). So, I do agree that the SE driver does not allocate
what is freed by iommu_fwspec_free(), but I feel this line is a bit mislead=
ing.