Received-SPF: pass (google.com: domain of linux-crypto+bounces-4578-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 31 May 2024 14:47:59 +0900
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH 1/3] crypto: scomp - Add setparam interface
Message-ID: <20240531054759.GE8400@google.com>
References: <cover.1716202860.git.herbert@gondor.apana.org.au>
 <84523e14722d0629b2ee9c8e7e3c04aa223c5fb5.1716202860.git.herbert@gondor.apana.org.au>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <84523e14722d0629b2ee9c8e7e3c04aa223c5fb5.1716202860.git.herbert@gondor.apana.org.au>

On (24/05/20 19:04), Herbert Xu wrote:
[..]
> +int crypto_scomp_setparam(struct crypto_scomp *tfm, const u8 *param,
> +			  unsigned int len)
> +{
> +	struct scomp_alg *scomp = crypto_scomp_alg(tfm);
> +	int err;
> +
> +	err = scomp->setparam(tfm, param, len);
> +	if (unlikely(err)) {
> +		scomp_set_need_param(tfm, scomp);
> +		return err;
> +	}
> +
> +	crypto_scomp_clear_flags(tfm, CRYPTO_TFM_NEED_KEY);
> +	return 0;
> +}

Is the idea here that each compression driver will have its own structure
for params?

In other words, something like this?

static int setup_tfm(...)
{
...
	this_cpu->tfm = crypto_alloc_comp(name, 0, 0);

	if (!strcmp(name, "zstd")) {
		struct crypto_comp_param_zstd param;

		param.dict = ...
		param.cleve = ...

		crypto_scomp_setparam(tfm, &param, sizeof(param));
	}

	if (!strcmp(name, "lz4")) {
		struct crupto_comp_param_lz4 param;
		...
	}

	if (!strcmp(name, "lzo")) {
		struct crupto_comp_param_lzo param;
		...
	}
...
}

Or should it be "struct crypto_comp_params param"?