Received-SPF: pass (google.com: domain of linux-crypto+bounces-4579-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 31 May 2024 14:49:33 +0900
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH 3/3] crypto: acomp - Add comp_params helpers
Message-ID: <20240531054933.GF8400@google.com>
References: <cover.1716202860.git.herbert@gondor.apana.org.au>
 <7b5e647f760c4deacf81d3b782f1beee54de3bbc.1716202860.git.herbert@gondor.apana.org.au>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7b5e647f760c4deacf81d3b782f1beee54de3bbc.1716202860.git.herbert@gondor.apana.org.au>

On (24/05/20 19:04), Herbert Xu wrote:
[..]
> +
> +	params->dict = kvmemdup(dict, len, GFP_KERNEL);
> +	if (!params->dict)
> +		return -ENOMEM;
> +	params->dict_sz = len;
> +
> +	return 0;
> +}
> +EXPORT_SYMBOL_GPL(crypto_comp_getparams);
> +
> +void crypto_comp_putparams(struct crypto_comp_params *params)
> +{
> +	kfree(params->dict);

kvfree()?

> +	params->dict = NULL;
> +	params->dict_sz = 0;
> +}
> +EXPORT_SYMBOL_GPL(crypto_comp_putparams);