Received-SPF: pass (google.com: domain of linux-crypto+bounces-4601-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <693df34f-c387-48a5-bbb9-1fa2e3077da8@denx.de>
Date: Fri, 31 May 2024 12:04:06 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/2] hwrng: stm32 - cache device pointer in struct
 stm32_rng_private
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org,
 Gatien Chevallier <gatien.chevallier@foss.st.com>,
 =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>,
 Alexandre Torgue <alexandre.torgue@foss.st.com>,
 Maxime Coquelin <mcoquelin.stm32@gmail.com>,
 Olivia Mackall <olivia@selenic.com>, Rob Herring <robh@kernel.org>,
 Yang Yingliang <yangyingliang@huawei.com>, kernel@dh-electronics.com,
 linux-arm-kernel@lists.infradead.org,
 linux-stm32@st-md-mailman.stormreply.com
References: <20240516193757.12458-1-marex@denx.de>
 <20240516193757.12458-2-marex@denx.de> <ZllavXc2lscS9TRc@gondor.apana.org.au>
Content-Language: en-US
From: Marek Vasut <marex@denx.de>
In-Reply-To: <ZllavXc2lscS9TRc@gondor.apana.org.au>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 5/31/24 7:06 AM, Herbert Xu wrote:
> On Thu, May 16, 2024 at 09:37:41PM +0200, Marek Vasut wrote:
>> Place device pointer in struct stm32_rng_private and use it all over the
>> place to get rid of the horrible type casts throughout the driver.
>>
>> No functional change.
>>
>> Acked-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
>> Signed-off-by: Marek Vasut <marex@denx.de>
> 
> I think you should remove the assignment of rng.priv too as nothing
> should use it anymore after your patch.

Fixed in V3, thanks.