Received-SPF: pass (google.com: domain of linux-crypto+bounces-4602-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <f1febadb-4cbd-4278-a3b0-dbb93d5af212@huawei.com>
Date: Fri, 31 May 2024 18:09:03 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] crypto: hisilicon/zip - optimize the address offset
 of the reg query function
To: Herbert Xu <herbert@gondor.apana.org.au>
CC: <davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
	<linux-crypto@vger.kernel.org>, <shenyang39@huawei.com>,
	<liulongfang@huawei.com>, <qianweili@huawei.com>
References: <20240506115953.2282155-1-huangchenghai2@huawei.com>
 <20240506115953.2282155-3-huangchenghai2@huawei.com>
 <ZlmZh5d8RDo3C-HS@gondor.apana.org.au>
From: huangchenghai <huangchenghai2@huawei.com>
In-Reply-To: <ZlmZh5d8RDo3C-HS@gondor.apana.org.au>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


在 2024/5/31 17:33, Herbert Xu 写道:
> On Mon, May 06, 2024 at 07:59:53PM +0800, Chenghai Huang wrote:
>> @@ -807,6 +786,18 @@ static int hisi_zip_regs_show(struct seq_file *s, void *unused)
>>   
>>   DEFINE_SHOW_ATTRIBUTE(hisi_zip_regs);
>>   
>> +static void __iomem *get_zip_core_addr(struct hisi_qm *qm, int core_num)
>> +{
>> +	u32 zip_comp_core_num = qm->cap_tables.dev_cap_table[ZIP_CLUSTER_COMP_NUM_CAP_IDX].cap_val;
>> +
>> +	if (core_num < zip_comp_core_num)
>> +		return qm->io_base + HZIP_CORE_DFX_BASE +
>> +			(core_num + 1) * HZIP_CORE_ADDR_INTRVL;
>> +
>> +	qm->io_base + HZIP_CORE_DFX_DECOMP_BASE +
>> +		(core_num - zip_comp_core_num) * HZIP_CORE_ADDR_INTRVL;
>> +}
>> +
> This doesn't even build.

I'm so sorry, I forgot to build it. I'll build and verify it carefully next time.

The second version will be corrected and send soon.

Thanks,
ChengHai