Received-SPF: pass (google.com: domain of linux-crypto+bounces-4653-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 3 Jun 2024 14:15:08 +0100
From: Will Deacon <will@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Ard Biesheuvel <ardb@kernel.org>, linux-crypto@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64/crypto: Raise priority of NEON crct10dif
 implementation
Message-ID: <20240603131507.GD18991@willie-the-truck>
References: <20240521-arm64-crct10dif-neon-prio-v1-1-e2975754b8f3@kernel.org>
 <e103fabb-6854-4ce1-b4f9-6f6b7f912895@sirena.org.uk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e103fabb-6854-4ce1-b4f9-6f6b7f912895@sirena.org.uk>
User-Agent: Mutt/1.10.1 (2018-07-13)

On Wed, May 22, 2024 at 12:17:41PM +0100, Mark Brown wrote:
> On Tue, May 21, 2024 at 09:22:49PM +0100, Mark Brown wrote:
> > The NEON implementation of crctd10dif is registered with a priority of 100
> > which is identical to that used by the generic C implementation. Raise the
> > priority to 150, half way between the PMULL based implementation and the
> > NEON one, so that it will be preferred over the generic implementation.
> 
> That second NEON should be PMULL, sorry.

Sorry, I don't grok that now:

  | half way between the PMULL based implementation and the PMULL one

doesn't mean anything?

Will