Received-SPF: pass (google.com: domain of linux-crypto+bounces-4674-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 4 Jun 2024 14:09:15 +0900
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 1/3] crypto: scomp - Add setparam interface
Message-ID: <20240604050915.GA11718@google.com>
References: <cover.1716202860.git.herbert@gondor.apana.org.au>
 <84523e14722d0629b2ee9c8e7e3c04aa223c5fb5.1716202860.git.herbert@gondor.apana.org.au>
 <20240531054759.GE8400@google.com>
 <20240531063444.GG8400@google.com>
 <ZlmKX4dD1EcstVmN@gondor.apana.org.au>
 <20240601002415.GH8400@google.com>
 <ZlqbcKUTa5e3rOtH@gondor.apana.org.au>
 <20240603023447.GI8400@google.com>
 <20240603082856.GJ8400@google.com>
 <Zl2ABxcUmNYD1DoF@gondor.apana.org.au>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zl2ABxcUmNYD1DoF@gondor.apana.org.au>

On (24/06/03 16:34), Herbert Xu wrote:
> On Mon, Jun 03, 2024 at 05:28:56PM +0900, Sergey Senozhatsky wrote:
> >
> > Herbert, I'm not sure I see how tfm sharing is working.
> > 
> > crypto_tfm carries a pointer to __crt_ctx, which e.g. for zstd
> > is struct zstd_ctx, where it keeps all the state (zstd_cctx, zstd_dctx,
> > and compression/decompression workmem buffers).
> 
> That's the legacy compression interface.  You should be looking
> at the crypto_acomp interface which handles this properly.

Oh, I see, thanks, I didn't know about that, okay now I see what
you meant when you said that you'd not add setparams to legacy
scomp interface.

Alright, so this means

1) zram needs to be converted to acomp interface
2) scomp drivers that zram is using needs to become acomp compatible
   (for example, I don't think I see acomp support in crypto/zstd.c)
3) zram needs to support setparam
4) zram needs to support tfm sharing, so that setparam can be called
   once
5) crypto comp drivers need to start support setparam

That's quite a bit of work, I should admit.