Received-SPF: pass (google.com: domain of linux-crypto+bounces-4725-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <2bc7aa8a-5b1f-4753-834d-1e31140d6fe2@oracle.com>
Date: Tue, 4 Jun 2024 13:52:57 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9 05/19] x86: Secure Launch main header file
To: Jarkko Sakkinen <jarkko@kernel.org>, linux-kernel@vger.kernel.org,
        x86@kernel.org, linux-integrity@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org,
        kexec@lists.infradead.org, linux-efi@vger.kernel.org,
        iommu@lists.linux-foundation.org
Cc: dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, hpa@zytor.com, dave.hansen@linux.intel.com,
        ardb@kernel.org, mjg59@srcf.ucam.org,
        James.Bottomley@hansenpartnership.com, peterhuewe@gmx.de, jgg@ziepe.ca,
        luto@amacapital.net, nivedita@alum.mit.edu,
        herbert@gondor.apana.org.au, davem@davemloft.net, corbet@lwn.net,
        ebiederm@xmission.com, dwmw2@infradead.org, baolu.lu@linux.intel.com,
        kanth.ghatraju@oracle.com, andrew.cooper3@citrix.com,
        trenchboot-devel@googlegroups.com, ross.philipson@oracle.com
References: <20240531010331.134441-1-ross.philipson@oracle.com>
 <20240531010331.134441-6-ross.philipson@oracle.com>
 <D1RFYH41E4ZN.2D7LJBAZP71CB@kernel.org>
Content-Language: en-US
From: ross.philipson@oracle.com
In-Reply-To: <D1RFYH41E4ZN.2D7LJBAZP71CB@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?a2tyVTJIYzFoVFZsM3pSK3dZNy9EVytWVUdqcnlEc08vRFlsVVJlc3JQc2pP?=
 =?utf-8?B?U0lmOFNraThaUHQ4bjkxV3FsUElsZ1BIcDBTeGc1dEJyYVh0WW1TQUtCeGs1?=
 =?utf-8?B?ZWYraHBxZVBkS2ZDQis1eUFtSzRlTENHRGZvSjBkN0NRaDZIRTQ4ZERSaXZX?=
 =?utf-8?B?ejZwMHhSV0hwQ1ByRjRmc2J5SWFIV2ZpbnFSRGhMaklYTUdndU1KeXVTR3M2?=
 =?utf-8?B?aFJLc0Urc2dBSk41ejc4MkgrL3B1YS9zYS8ySkRvakM5Q2dHK3lPTUhORzYx?=
 =?utf-8?B?bmcrVXovcG9IL2pUN0h2VExYb0VCa1ZTcDVXRTNMcEhvR0NMNEFYeTM4Tit3?=
 =?utf-8?B?OTFRVnNPempMUUZzdkduTHArUFhWQURndThlcWs4dzM3eUl1TG9YY0ZpZUNQ?=
 =?utf-8?B?RGkvTkpSYkNXZmtCdk51SHk5amdMVEI0VFpWOHhnejhBaVJ6VTJCbHVyb1cw?=
 =?utf-8?B?L0t3QmkrK0J5aklFVE1tL0x5cnNiQnE2WlJlWGIvMEdOZ0R5MXlGUUl6b2Zh?=
 =?utf-8?B?YkNqRzN3eW9sRGFUWHdZSHJwTlRENG9SSGptTGxtV0pnNTdVQkRkZSt2ZExq?=
 =?utf-8?B?eXVQNFA2SzhyQVFzWENObHhGMzVlZFJrc2RibU9NSVA3TklwbWJLUHRuVTRB?=
 =?utf-8?B?T0p6MDRXSk1oTnhtQWtDQTYzc1FrcTV6OWhmQVUvMzNjeXh6NTh4aXYyNEdJ?=
 =?utf-8?B?VEREdTNqZUR4L0V3aXFaY3RZMlovQlZ4SkNYd2toK1E5Q2xXYXk0VUZXN1VT?=
 =?utf-8?B?ejZoZVFvM0V3cFB0ekd0eGExdjZPbXRWU3FTd3VTZlBKQTltODlSTzBFMUk1?=
 =?utf-8?B?bGRnWElUNTVkMzhCVDlKZzBLNkVEN20yU01kNzQyalNhV1BBbGJPbHQ5U2JB?=
 =?utf-8?B?YVp3d2tMeldCVU1UdWtsYjRzZHVtQlNQNTdLa3hmelZ6T042UlVWRUFiUVdH?=
 =?utf-8?B?eUdEZCtBRzVmdmxQY0VCUGNFTUlIelVyUTZYdGY2M3hoN25tMW5vR1N1THJu?=
 =?utf-8?B?YTFHZlA1dStzbFpOcTVsWmg3bC9Hd3BIamo1b0ttRkdwenQ4YVRUcmYyRGNE?=
 =?utf-8?B?Y2p4NzhDNEVqWW94bGpOcE8yNnQvZkpVL2FwelFHc0YySHplRnRROEF1T0Mw?=
 =?utf-8?B?dExkN2FVTFd6MFZHZE82dWZ2SVRYU0FPTmdXMDdwNGVrM2xUOW9rMS8vWTFa?=
 =?utf-8?B?Q2lDNmZ4UTFHSDdDVmlRSndUZFhlUHJlUGFGLzI1eDV3T3RvVUZkQ0JhSkQ0?=
 =?utf-8?B?MWRtVjVPc0p5ZTNldGNHL21lVmVTNjhyaGJJNTFZSTRod1I0cHpWYTJPZTl4?=
 =?utf-8?B?Z2E0VVRKMG5OdEJwTFVKMGpxeFZPQ0EyWlU5UHlYeGlKUkdGVmtOamdiNE9K?=
 =?utf-8?B?YVVTd2ZENHNvbkhOYlZiRGo4V2xpN0lkZEpVeSsvU0VFZGdVUEdFZ3k4U2VT?=
 =?utf-8?B?NE9Sb25wY1V5RzdpOWErZ1pZbGU1MkZTQS9QV3VKbFJGS09adFVBWndZRk16?=
 =?utf-8?B?Um5xcFdxTjlJMmdRVE85V1JTbllaR055UTJNa3IyQ1NkbU13UkZYVEU2NU1n?=
 =?utf-8?B?bXZQY3NaVjhYengxcDVybXVITmR3L2YyQXJZak9oWEpxSHR2OWtwaTdPbkdF?=
 =?utf-8?B?MkwyV0Z3b09TREQ0dE11YjhsZXNZSVdJb3pqWE9maDllbXFCTDEyNWVvNHlE?=
 =?utf-8?B?K2pEZW40RW42TlNtSjZMaHNXRHg0ZzJ2Q21rL2RzNHFTV3VFWDF5cjRFcU9v?=
 =?utf-8?B?eiswN3VqZ0ZJSUlEamM1MWNhejdQTGErSExYUHV2TTVGeEJuYlM3amlXY3Qz?=
 =?utf-8?B?OW9OWEtud1RtTGFSZjZCSjRTNGoySC9Rc1l1Q0hxc1czeUFuUXFnTFZYV2p3?=
 =?utf-8?B?S0ZvQklPa2tPcjloVXFxVXZtc2pTVE1XenNhVmg2bnJuRmJZdm5DLzJXYXdl?=
 =?utf-8?B?N0VWTVRNRTdJWW1GQmdWZFVQY29zem9IT1lFdUdRK0doSDZBeDRETWZuWFhN?=
 =?utf-8?B?ZWg2MzZoUmpkaVkzTTIyYjV1U2J5N2E5aTg5SWViSEVBL1BSVkpXTmFLTERt?=
 =?utf-8?B?dlBJazYxeVYzYUhScVpxMzJaaWUxMG15L29PTFdnZXJMeTVpV1ZqNEozN0VM?=
 =?utf-8?B?MmM1ZGRkcThoazJLbkx4a3EyZ2RKbEljdmdpUkRmKy8zQ0I3aEhsemZ3aDRp?=
 =?utf-8?B?NFE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	GBpSHe8A4IE0WeNj5I8aRiA16wB+Mfi0lgu1Oj8Yx2RhJymwbhqllw+t8Nto1zTm64X6BquqjJ1ykdOudKyil4Uy5k+3/IMMeVYgMdXiB+XxLHQkLCW6Vjl5sak4OZCJLJqt2F3c8SQ+a6oQNUH9suh9PIrohek/Fagy3tbQjLcIN/QxuWJXisOKHLUUVj52V/F/jB/mKQGWSU9ZFvqG4kBnGpYfVHLu2iBHXdOw3uetM3oOMVRLsS8ShhvM6zpY6D3ZQnJR/Na49y8fQ7aBIYFik1UIPyft5UJIJq7XIWL/sOAJf29o08T8k3rDJG/tdtJDqaPZ6B/9trvAFlU1PIt7rsvvtwkmdOiDwZbMPoJD8Lx2Zfg9rMHfAv3PI8jizc+EO9zUQ68O2gpcbACA/1bGl7uQ5zM6b+krymwOx1voMYjmZh05fcSTvHLm5Ox+LKntzVo3ion8uQuKL8VcZB5pT0x43GQkbOm8NBLQ4HuLy5yABb5yjgfTns7xEw9ihQgSNWxj5ZW03oI+m+2Xj9dGTscWHTEYtihx/7cn3GK9esbNLQ8aKFAEEM8FtgvCRS+NWcXjC+bYOXogAmhEwoz/eEKF/zfC9Gh0Mmc0uXQ=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a126eb5-5159-4339-4afd-08dc84d85240
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7224.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 20:53:00.9185
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s1AIc26IE0pxSQxsgo1ojo+KxHqDafXAtnr/6x+VNG+8620CcllnQH5tJVal0ih+c4znMUiedXdVCkOXpfh826S1u8zgW7ZGiG1aijLMoNg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4937
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-04_11,2024-06-04_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2406040168
X-Proofpoint-ORIG-GUID: BJ-iJVnaGAW56UwMw1vcptIbzgdObSdQ
X-Proofpoint-GUID: BJ-iJVnaGAW56UwMw1vcptIbzgdObSdQ

On 6/4/24 11:24 AM, Jarkko Sakkinen wrote:
> On Fri May 31, 2024 at 4:03 AM EEST, Ross Philipson wrote:
>> Introduce the main Secure Launch header file used in the early SL stub
>> and the early setup code.
>>
>> Signed-off-by: Ross Philipson <ross.philipson@oracle.com>
> 
> Right and anything AMD specific should also have legit references. I
> actually always compare to the spec when I review, so not just
> nitpicking really.
> 
> I'm actually bit confused, is this usable both Intel and AMD in the
> current state? Might be just that have not had time follow this for some
> time.

This header file mostly has TXT/Intel specific definitions in it right 
now but that is just because TXT is the first target architecture. I am 
working on the AMD side of things as we speak and yes, AMD specific 
definitions will go in here and later ARM specific definitions too.

If you would like to see say a comment block with links to relevant 
specifications in this header file, that can be done and they will be 
added as new support is added.

Thanks
Ross

> 
> BR, Jarkko
>