Received-SPF: pass (google.com: domain of linux-crypto+bounces-4732-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <49ef4f0a-683b-ca2a-20a9-65820f8c5e37@amd.com>
Date: Tue, 4 Jun 2024 16:36:49 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v2] crypto: ccp - Fix null pointer dereference in
 __sev_snp_shutdown_locked
Content-Language: en-US
To: Kim Phillips <kim.phillips@amd.com>, Ashish Kalra <ashish.kalra@amd.com>,
 John Allen <john.allen@amd.com>, Herbert Xu <herbert@gondor.apana.org.au>,
 "David S . Miller" <davem@davemloft.net>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
 linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
 stable@vger.kernel.org, Liam Merwick <liam.merwick@oracle.com>
References: <20240604174739.175288-1-kim.phillips@amd.com>
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20240604174739.175288-1-kim.phillips@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RmJlS1Y4amdkS1pJeFJIb1AzbFo4ZkV3WWwzNCtWb1FUOHYvL01OYS8rM0lP?=
 =?utf-8?B?ZExRMDVpTXZBdVRhV0pKWVNwOGhaSUV6OVRLcWVWTDZBL3A3V2gycC9nVmxi?=
 =?utf-8?B?cXdCcmZtaGRkcHZBQmRTR1QrazNkcGdIVzhEb0twa0xSL1UveFJBSzBtazVs?=
 =?utf-8?B?UURzTUJrZEhYL01QR0p5RmlnQVNOQi9NcDQ1V240TG4wOU13Um1uZjdVaGtv?=
 =?utf-8?B?M0Z6QkNrazl1c3REdEZtN2d0Y0s0dm5ISkk5eXdEb3QyMVZvYm9zMU4yeEYz?=
 =?utf-8?B?alpWMVMzbjYvdHRlMzdZTnluYXBIdWtQWGRUZnRFWG9mYTNzc2ZReTNnTkc0?=
 =?utf-8?B?R2QraENEK090cE51cVJHM2tvV21OdFkydEdoby9CUmNLQlVhVFpnMXZzcGVX?=
 =?utf-8?B?TGloTkVhNldPUklGYlFkWGhRWmpQUnlqYXhteHg5bk5wekRuODczekNUVzNS?=
 =?utf-8?B?N3RCUEo0NEJpcmFLZHIxRUxzYWVhdFpGK1NvcC80cHdQRXBhMTRZRHE5aWV2?=
 =?utf-8?B?eUxvTC9WeG11c3p3LzBrMThVL0Jka3lSaitHVncvM2NPU2l3ZDROYzJTRXRr?=
 =?utf-8?B?V0l2dmxvVmFBYVNDVGdQVTJtVyttOTZEQnlTaHJQVjZIbGJPUWwzQjIyL2c3?=
 =?utf-8?B?N3JXcE1adU5ra0RLcnRpc0NKTEc2YUcrSkp0T1hXcUdjbkpwZ3pBRG9zMGtP?=
 =?utf-8?B?Z3g2NUlwT1AySTYxbmxNYlZpSU5HQ0k3amhZM3hjbkRUczRNeTVNMndjTDNH?=
 =?utf-8?B?ZkhiRm9WRERldHVuVmQybzg1WkhaR1VQc20xdWhpTnB6WG9EV1Z0bWlBRFVG?=
 =?utf-8?B?b1JQREJVeGh1cFdTSFFsS0cydUFkamk5cXIxSnd5cFl0QWhYVHlzSUVnb2Zi?=
 =?utf-8?B?dU9HOCsra3ZRbWdKZDJJckVCalZMVWhUTnlUaXR6TkNXSWZrVWxiQkRyOUNL?=
 =?utf-8?B?ck1qNnN2SUJaUmRlYU5sL3pOSkUrRWp0U0ErbStEc0p2aDdMODgreHZ2SG8w?=
 =?utf-8?B?Q1ZJWmduRVNBM2NhRml6ZnJZSUswUWllclVMd2UzYmNSSDBOalNoMTNKMVZy?=
 =?utf-8?B?dURhUVF5bE12cGtsNmlaeFVKZjc3QmpCemlYRERGbXpBQkRFaTZEV2lBZUlr?=
 =?utf-8?B?blJDOHV5RVpUQWV1dk9KakpYenB0N205RXpTc0xyWWFDMGNDeTRDbkhoRnVs?=
 =?utf-8?B?UXhQVGZYaDUxQjh5NlFmWHFwaUZlQWh2TDBFcjNOQ0pFTFRXQnhtaEJXZVNp?=
 =?utf-8?B?QXQ0WElnODlSRlVDdWN0clFYL2ZCdy82aWdaSkJ6VjN5eFExWERQZlJ6SW9s?=
 =?utf-8?B?d0dyaWtDVk5DVW5QWGZMcVpGU2IrMk5IUUlCcTEzMnF0VkZwVThqSmZTdVdN?=
 =?utf-8?B?Z2t1M00zVXpxNnZiUXBmOURuQVpXaUttRW5FU3ZGalVRd2Z3eTdiR1NZV3h1?=
 =?utf-8?B?d1h2bUM2VmdEUEwvd3BpSXJTdk5IYWVvRFpjM3BoL2JlQzZFaEhwdjMzb2w4?=
 =?utf-8?B?aFVDZTlONmNOVGhwb2VpU1lOeDhyV210ZDNWUU1HWUxsN3ZZN0pLR2JGNlF6?=
 =?utf-8?B?Ykd2R0VkeWFlenUyL3dqK1BCY0lkTDYvZk1yaW5LWHYzcG1yQjB2Rno1a21s?=
 =?utf-8?B?TEE3dFlmVnRlNG9wNnZqUExId0FCcUNqQ1NYRjU4dkVMWXE0WElCNGlTQUJ5?=
 =?utf-8?B?QVlzSXZWSTlZWkxOTjBpTE9idjVHYS9BTC9wNnEveGQ5S1k2TmlrUzl0TzlY?=
 =?utf-8?B?cXJVajJIZmgxRXNOWnE5SW9RaDBIb0pYZjRoUjFTQlNQVlBYVW9sdGRObUV4?=
 =?utf-8?B?bGRMRHVtOEw3a2xqOFNoS01XcW85MUVBaFpYVEFNMEs3aWdDbCtnbHQwYlJL?=
 =?utf-8?B?YXAzVXArMUxEdHNTTlNwTTR4K2hrZ3RLRjFhZ1B5cEdvdGpJcFFwY2V5endp?=
 =?utf-8?B?Zy9EdGxGTUhKMThEbVArR2FxVk4vazhCZ2xLSnErNkFHWFZ3OFpDY3ZNa2U5?=
 =?utf-8?B?Rk94NkU3NkxwMmQ3VXdQRnFpcjA0U2E2KzQwbWxhSGRJdFBNOXZVZkZ5Y2NU?=
 =?utf-8?B?Q3FOVlhrSVpUTmhMblNnZ1l0WlMwaEZxZ2d6NWl3SjFINzMxSXVPcUMxNkl4?=
 =?utf-8?Q?2+LzzgGu08rDo7H83QP7iYvFl?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0fdbf95-a7fc-4d55-f9d4-08dc84de7235
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 21:36:51.5262
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uODF1g/+Xikewebp0Gykg/8OBJs2E47U7097fJwdOC6A4khHbsbxzinqYqqOSD6OOIKj+NUeUvuMu2LjR1552A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4492

On 6/4/24 12:47, Kim Phillips wrote:
> Fix a null pointer dereference induced by DEBUG_TEST_DRIVER_REMOVE.
> Return from __sev_snp_shutdown_locked() if the psp_device or the
> sev_device structs are not initialized. Without the fix, the driver will
> produce the following splat:
> 

> 
> Fixes: 1ca5614b84ee ("crypto: ccp: Add support to initialize the AMD-SP for SEV-SNP")
> Cc: stable@vger.kernel.org
> Signed-off-by: Kim Phillips <kim.phillips@amd.com>
> Reviewed-by: Liam Merwick <liam.merwick@oracle.com>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Reviewed-by: John Allen <john.allen@amd.com>

Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
> v2:
>   - Correct the Fixes tag (Tom L.)
>   - Remove log timestamps, elaborate commit text (John Allen)
>   - Add Reviews-by.
> 
> v1:
>   - https://lore.kernel.org/linux-crypto/20240603151212.18342-1-kim.phillips@amd.com/
> 
>   drivers/crypto/ccp/sev-dev.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
>