Received-SPF: pass (google.com: domain of linux-crypto+bounces-4734-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <282fddde-d156-4bd3-906b-0318d0a3746d@oracle.com>
Date: Tue, 4 Jun 2024 15:14:38 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9 16/19] tpm: Add ability to set the preferred locality
 the TPM chip uses
To: Jarkko Sakkinen <jarkko@kernel.org>, linux-kernel@vger.kernel.org,
        x86@kernel.org, linux-integrity@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org,
        kexec@lists.infradead.org, linux-efi@vger.kernel.org,
        iommu@lists.linux-foundation.org
Cc: dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, hpa@zytor.com, dave.hansen@linux.intel.com,
        ardb@kernel.org, mjg59@srcf.ucam.org,
        James.Bottomley@hansenpartnership.com, peterhuewe@gmx.de, jgg@ziepe.ca,
        luto@amacapital.net, nivedita@alum.mit.edu,
        herbert@gondor.apana.org.au, davem@davemloft.net, corbet@lwn.net,
        ebiederm@xmission.com, dwmw2@infradead.org, baolu.lu@linux.intel.com,
        kanth.ghatraju@oracle.com, andrew.cooper3@citrix.com,
        trenchboot-devel@googlegroups.com, ross.philipson@oracle.com
References: <20240531010331.134441-1-ross.philipson@oracle.com>
 <20240531010331.134441-17-ross.philipson@oracle.com>
 <D1RIKP548WG9.Q5MM7K3FRH4P@kernel.org>
Content-Language: en-US
From: ross.philipson@oracle.com
In-Reply-To: <D1RIKP548WG9.Q5MM7K3FRH4P@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?dkVzc2dHMzlFR2Qra0pDbE56MEdIcUs2R1paMHV6b0gzSCtJVHN6U050N3Vv?=
 =?utf-8?B?NklNbjRxcDh0UllBNW1sZzNVZWJHTmpRL2oxOEI2WEpqREk0ZUFDODlDSysz?=
 =?utf-8?B?aVpOMHVneTJMTHVlTHlPY2lrY2gyQWk1QkU2dWkwTkN0cUFiV2NoYVdUTjZN?=
 =?utf-8?B?cG52OW5ma0NYY2h6eW16VW1Xdi8wZXJQcGZsRzRwMDVkaVlmRUhhcXIwTDNv?=
 =?utf-8?B?WGNOZzVYeVhTWmh6M3g4VTNPWU1BMFFidS9ld3p3UUtKVWZnUXZJaDFNaFVV?=
 =?utf-8?B?bmY3Q0VoL2xHWmpsMHZoS0tQdTd2Wi9XZFc3cHhtcTFScUp0NTRaWGY4Z29S?=
 =?utf-8?B?eUZ5S0s0WXp2VzNINkc0bUFFRkJFNW03STRwSC9lQkp4TDdmcXFka0NpNXMx?=
 =?utf-8?B?L1I4U0hTYmhrTHlXeDg0TnJoaURNYXovcEhqVTQxUmU4Tmo5elVRbVJGQVd5?=
 =?utf-8?B?ZVFTL1Y2SXNZMW1HMmZ2Rk9ZU0FuWTIxZEd3SEZyaWpxeUNnSzlLNnFFR2ky?=
 =?utf-8?B?RC9EL3A4aTlPeiswQ1JiRFpDRE5WcEJUd0RwN1Qzc0N3bXZDbGhuK0tGZ2FD?=
 =?utf-8?B?U0MvWE5haUo5ME8xRWI4VGJ2amZlYTNNR1lzZXM3NFJTeEtraVVudUNHQ0pI?=
 =?utf-8?B?U0QwNFZDWml5LzRLakpmRXFYbWs3WWIxaHIwV2pLbXBaY3NwdXlKWGpZK2FV?=
 =?utf-8?B?UkkzSG4vTnhYZnNidFNFOVI1ZmJtTzcvakhQSU0zYzQybHU1bGJqZlQwR1Fo?=
 =?utf-8?B?YVhRa2ZGdWpOUjJMNUhXekh4MmNqMHpoUEp6c0lkTncrbXFGK0FBdk9TUFlO?=
 =?utf-8?B?SldxcUpEdGdPeStJbWdKTEpSUmh3MGNla0ZTbVhLU2krK0NFVTd4blJ2bUJU?=
 =?utf-8?B?QXV6WjkwaXhaYTlObHp6ZGFMeVp0djFNN0pXVTltTzMrMDU3eHlzbzcxOThC?=
 =?utf-8?B?ak50RjhLc0pQa09OZjAwZlVDbUQ5QUV2c2ZoeWcyUm5YK25sRjk2YWtSb1U3?=
 =?utf-8?B?RzFMckdVZm04eGkycWhNT2wwNVprOWMvNUFSU1VaUmpsV3BMTjZYS0NWTWdH?=
 =?utf-8?B?V2hjVk8wMk81bmpjOVcwQkNQNlcrdkJsNTNkZUZyRW5wdnorNmRXeVFiZGg1?=
 =?utf-8?B?TFF1UU1vM01GazlCOXc4L0RYeityR3lITDBscTc5dnBhajQzeVFHRlVlZjYv?=
 =?utf-8?B?SzlHKzk4ZW9PdVpSRVZMQ1NlM3NTT1Z2cFgwNlpURjlJZU1nQzVHa0I1dDNy?=
 =?utf-8?B?eUdrNjVtWkpWQ3ZqNnVYclUrYk42U28xQVM1K1k5aUxVYktPTmZtNUp3UDls?=
 =?utf-8?B?OXBvQk1VOVd2dXA4TmpJRE5kWWNIUDZ5bTMvcXdUY2Z3MXd5dlY5a3hLc2s3?=
 =?utf-8?B?R3JHUjl2UXk4TlBSRVdnWWVpZS9uc0orMzZQNktCVDJTQ29sS0plUGpnK1BW?=
 =?utf-8?B?U3B1c3lpYlJJNGhpb0xDTXBaMlJZeVR4T2hDSkV5UFdmSEpDMkJEZy9GWWE5?=
 =?utf-8?B?aEx5UjFkTk5pOU5xY0ZIVmFsMDhGYU1PN3FGWDdjcWFkdFR3VjhheEJta2V0?=
 =?utf-8?B?UnlrbHEraUZMSk9JLytCZE1ocmtBeDVGdVpXeGtoUi9yQi9iODJRWWEwcnZ6?=
 =?utf-8?B?eENDS2t2WUx5VEJ3WWVWUnhTSitFL1hHUm9HQW84aXNZQnlrNmlpUkF3U29X?=
 =?utf-8?B?aGZQek85OVRIMEZLeXdkR3ljYjQzaXJCRHRCdFVaL0U3NjN6KzlIc3ZVa3BN?=
 =?utf-8?B?SGpxb2IzWm0rQ1k2d0JrN1N0TEtGamtTREFYd25mc2pZMFRNRm5Yd1U3eVc3?=
 =?utf-8?B?RTVaOXpYMHpnVjhoZFhoY2lkZ0NHU2RIQkljVVM3TFR3NDRrY0ZkVm94WXcr?=
 =?utf-8?B?QzZRTWJobGZ1WFZhYmVrdmp2TGJIc1ltSVBHVm9qQk5JWUlyOXpWcDFHdS9M?=
 =?utf-8?B?R0hVZWdUMWIrTTMySEF4cFdMY3owazJzTVh0Y1QwbXBPcTZjQTFPRXVkcDFl?=
 =?utf-8?B?WVpSSkU0djNkQkQ5UEdkUWdVZUltc1E0K2F0THBCd0hDYnNObW9ON1BkN2dW?=
 =?utf-8?B?ZFVvYjhSc0ZmK0JzSVNNWklmSjVNL2FpNmZGKzFQd2grMkRBUzNvN3l3OVc2?=
 =?utf-8?B?U3pRV042QkI3TDFzVnFMWkFHd3JsZWZFeGRubHBTT0NFQ1Mxa3ZjTkp3TjNr?=
 =?utf-8?B?MUE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	TYYIfo/FAjGNzDV3sbHQhj0cZljk0HTP9+9VC1r0+fA2C8VZGuDNOX6rJnZe0HwiGLjM3zlBkp/Pooa3FLhY7bLWK6dIgrz0pJAuRQG9d3tEJAwcPbl8a3aRDU5ohbbDbJ08Yc3GLQ3M6HTJqO08yguFrpAIluanXhByXI++kSucUXx2dwYQPofvDtkQKQt3xcUA6V+YhZsnlfntLUVM4Qq4NId9UckaRJleGEhXvCmNNmlwP7sIVoPlesvSN2ZMj9ZrIRCv3Rbp5j5K9AM9Cq+tsz4Yrq3fmZkiKyPixM5LOX31Bdcww86XWIvLI/WS2LDMusSOXXHsg54bf91WgOajrY7r8DnyXiSSDhwoi94EBZPoiF4YLmPE80ANRGRjZ+3mAzYZnOVLjQp+ZB6TDzVfOt6F4ogjmwpf3KN0fd3LgKpFa6T6AjcfZzu1ZVywJJEQ33tdgUva9+OZG2ds3hA5CKtWFdvcyt63sYA1gRBO31ok79ezSDME90UOI2VITy6OKdPFX+CqO8n5YwkIODd1lqYHC6koAKbzMIsU1TCffV/PIAX4kMg2XfehrdEoDIzH0iJr/hhYtcUvG/4nHyboRSUUk3NxAj4A/Ei2m9Y=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6580f0ca-a55c-40a4-388b-08dc84e3bd80
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7224.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 22:14:45.3637
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FA/NDxelLLkXOIggWIh+XbNLL0ecJHZJBFLtEgWk3Qo0qdijgepH+1odRip2zPRMwcmjYcT/wA4pEGACvkk/0Sd0lB0M1vrtUu+7/JFg7Tk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH4PR10MB8025
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-04_11,2024-06-04_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0
 phishscore=0 suspectscore=0 bulkscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406040180
X-Proofpoint-GUID: zBIft3hJof5EGLdWBMrp0r7bRBujpLAE
X-Proofpoint-ORIG-GUID: zBIft3hJof5EGLdWBMrp0r7bRBujpLAE

On 6/4/24 1:27 PM, Jarkko Sakkinen wrote:
> On Fri May 31, 2024 at 4:03 AM EEST, Ross Philipson wrote:
>> Curently the locality is hard coded to 0 but for DRTM support, access
>> is needed to localities 1 through 4.
>>
>> Signed-off-by: Ross Philipson <ross.philipson@oracle.com>
>> ---
>>   drivers/char/tpm/tpm-chip.c      | 24 +++++++++++++++++++++++-
>>   drivers/char/tpm/tpm-interface.c | 15 +++++++++++++++
>>   drivers/char/tpm/tpm.h           |  1 +
>>   include/linux/tpm.h              |  4 ++++
>>   4 files changed, 43 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
>> index 854546000c92..73eac54d61fb 100644
>> --- a/drivers/char/tpm/tpm-chip.c
>> +++ b/drivers/char/tpm/tpm-chip.c
>> @@ -44,7 +44,7 @@ static int tpm_request_locality(struct tpm_chip *chip)
>>   	if (!chip->ops->request_locality)
>>   		return 0;
>>   
>> -	rc = chip->ops->request_locality(chip, 0);
>> +	rc = chip->ops->request_locality(chip, chip->pref_locality);
>>   	if (rc < 0)
>>   		return rc;
>>   
>> @@ -143,6 +143,27 @@ void tpm_chip_stop(struct tpm_chip *chip)
>>   }
>>   EXPORT_SYMBOL_GPL(tpm_chip_stop);
>>   
>> +/**
>> + * tpm_chip_preferred_locality() - set the TPM chip preferred locality to open
>> + * @chip:	a TPM chip to use
>> + * @locality:   the preferred locality
>> + *
>> + * Return:
>> + * * true      - Preferred locality set
>> + * * false     - Invalid locality specified
>> + */
>> +bool tpm_chip_preferred_locality(struct tpm_chip *chip, int locality)
>> +{
>> +	if (locality < 0 || locality >=TPM_MAX_LOCALITY)
>> +		return false;
>> +
>> +	mutex_lock(&chip->tpm_mutex);
>> +	chip->pref_locality = locality;
>> +	mutex_unlock(&chip->tpm_mutex);
>> +	return true;
>> +}
>> +EXPORT_SYMBOL_GPL(tpm_chip_preferred_locality);
>> +
>>   /**
>>    * tpm_try_get_ops() - Get a ref to the tpm_chip
>>    * @chip: Chip to ref
>> @@ -374,6 +395,7 @@ struct tpm_chip *tpm_chip_alloc(struct device *pdev,
>>   	}
>>   
>>   	chip->locality = -1;
>> +	chip->pref_locality = 0;
>>   	return chip;
>>   
>>   out:
>> diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
>> index 5da134f12c9a..35f14ccecf0e 100644
>> --- a/drivers/char/tpm/tpm-interface.c
>> +++ b/drivers/char/tpm/tpm-interface.c
>> @@ -274,6 +274,21 @@ int tpm_is_tpm2(struct tpm_chip *chip)
>>   }
>>   EXPORT_SYMBOL_GPL(tpm_is_tpm2);
>>   
>> +/**
>> + * tpm_preferred_locality() - set the TPM chip preferred locality to open
>> + * @chip:	a TPM chip to use
>> + * @locality:   the preferred locality
>> + *
>> + * Return:
>> + * * true      - Preferred locality set
>> + * * false     - Invalid locality specified
>> + */
>> +bool tpm_preferred_locality(struct tpm_chip *chip, int locality)
>> +{
>> +	return tpm_chip_preferred_locality(chip, locality);
>> +}
>> +EXPORT_SYMBOL_GPL(tpm_preferred_locality);
> 
>   What good does this extra wrapping do?
> 
>   tpm_set_default_locality() and default_locality would make so much more
>   sense in any case.

Are you mainly just talking about my naming choices here and in the 
follow-on response? Can you clarify what you are requesting?

Thanks
Ross

> 
>   BR, Jarkko