Received-SPF: pass (google.com: domain of linux-crypto+bounces-4742-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <249a9b27-c18d-4377-8b51-9bc610b53a8b@oracle.com>
Date: Tue, 4 Jun 2024 16:00:01 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9 04/19] x86: Secure Launch Resource Table header file
To: Jarkko Sakkinen <jarkko@kernel.org>, linux-kernel@vger.kernel.org,
        x86@kernel.org, linux-integrity@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org,
        kexec@lists.infradead.org, linux-efi@vger.kernel.org,
        iommu@lists.linux-foundation.org
Cc: dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, hpa@zytor.com, dave.hansen@linux.intel.com,
        ardb@kernel.org, mjg59@srcf.ucam.org,
        James.Bottomley@hansenpartnership.com, peterhuewe@gmx.de, jgg@ziepe.ca,
        luto@amacapital.net, nivedita@alum.mit.edu,
        herbert@gondor.apana.org.au, davem@davemloft.net, corbet@lwn.net,
        ebiederm@xmission.com, dwmw2@infradead.org, baolu.lu@linux.intel.com,
        kanth.ghatraju@oracle.com, andrew.cooper3@citrix.com,
        trenchboot-devel@googlegroups.com, ross.philipson@oracle.com
References: <20240531010331.134441-1-ross.philipson@oracle.com>
 <20240531010331.134441-5-ross.philipson@oracle.com>
 <D1RFWFIJEYWL.2FC7V79321264@kernel.org>
 <1eca8cb1-4b3b-402b-993b-53de7c810016@oracle.com>
 <D1RLBMTUKRFN.34KQXEFZTBA08@kernel.org>
Content-Language: en-US
From: ross.philipson@oracle.com
In-Reply-To: <D1RLBMTUKRFN.34KQXEFZTBA08@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?SlUyKzJId0tYK1VrbEhHc2pXQ0xMUkxvY1EzaVJTSW42Mi9nUVNYQ2lJOHhC?=
 =?utf-8?B?SSs3RVd5cG55Nm9nQW10TTlpTExZNTlYeHdUL0h4b0ZWM0pZamM5RW9mTzhF?=
 =?utf-8?B?NFV4YTAvUWtrcnFwb2N4WmJtMDUwZWJrRC80N25JY0xjbTVLYy9aS2VlVGNK?=
 =?utf-8?B?RFVRYVRuZXNuZ1ZkMTJ1RkxVamZoVDZyMFRucWtUQWs1N2pkMXJyVk9wVG9R?=
 =?utf-8?B?WWYxTFViTzltZkcyRUh0SDhGb0l2NUw3aWd4YWdSbWZISjdaQmV0bVBxbEc3?=
 =?utf-8?B?UkhHZ1FwSXh4U2hDVy9xZm8yUk1JRjMrYk5EV3J2NzAzMG9YT1dEVk5BN1NZ?=
 =?utf-8?B?V1B0eEswRnpoL1RiS2pvWGhBelRhY29CWVgzbTl1bkt2VlRjZGI5VGhKYjFz?=
 =?utf-8?B?ZjljY00vZVRBM2FYL2RKMy83cDM4MXZwTkVYaklYSE5EcG5JSCtQYWpTV0FB?=
 =?utf-8?B?V0k2KzByNmFQMEZrU1ludWxpaGFneWdRUVRWS0N1bnlaQXFEUUV5cU83dU1N?=
 =?utf-8?B?OFc3aXhsMW5kZW1HcUFjVHpSWXk5aXNZUXdDcll2SmoxR3JxVUFLdHUyYm9Q?=
 =?utf-8?B?MVZqK0pJMWl1YWorRlRCNnArbzVHcjN0WkcvQ0dIazlmVWNkWjhmc3dpWXR6?=
 =?utf-8?B?K1VzY0FYVFY3cStMMjkxMmZJSWdHWWp6UzRWc2tEQzRadnNtaVF6MWExbDlG?=
 =?utf-8?B?alg4OUw1cDkvUjZyRGo4MmljV3ZyVnVtY3V5SnpGemkrSFhRTlIrVVNiSTZT?=
 =?utf-8?B?anZLU1NDU21tVjhFZngrdEJFejRPN1JZbjlWZXdLeml4ZFQ1c1d1d3hLcjkv?=
 =?utf-8?B?cEYxNHBGQWREU083T0pMZk4wZ0FqaTJ0ZkFxcmp2OW9wazJCdHdtR3BmaU9T?=
 =?utf-8?B?MVVyNXpKa1BZaC9peU5FYjErc29NZXlmRElZVEVad2ZyMloybkwvSUVNZ1JG?=
 =?utf-8?B?bEV5VkozU1JqVnBjM3pHSCtXc0wxamp4Ty8yVHI3Qk0vSmdHOE0vUzhOZU4v?=
 =?utf-8?B?cDYrNWJ5c2xzNnpTSkYyN3daLy9nWDV2WWg4WFM2MnFmL0daTEUzTzdhQmNX?=
 =?utf-8?B?ZzVQUDZJWU03cUtKSVZRVzdpWUtZTGZhVnpJVnVON3AxZS9lMS9aTE8zT1FN?=
 =?utf-8?B?NmlTYnVzNmpVYk9SemJ3UXZPeU5uMUVndW9laFBBR0tUL2xHSkRSVHMwUFNM?=
 =?utf-8?B?UHVwNEsxeDVKalZhK04xR3c2R3pFWjhieWRoYmxqZHBmZmdIMUR3OFJ1SEw2?=
 =?utf-8?B?ayt0eVNsTDRFODBZWmoyRE4vc25xYjdqRFp3TFRacHlBZ25oY2lTc2xIa01P?=
 =?utf-8?B?Zk4raTZ0YkM1MkR3eVV2bXlIVjlUUVgrVElDWWRNVFhhZEgxdXdqVTdnL3Zr?=
 =?utf-8?B?Y2cvTDBDN1NJRlM1Y1RSd3Rza3BsaVhvSHB0YWJKT1dDYTZ3RXhLVFd5elp2?=
 =?utf-8?B?dmN3djhnUFpkVFc1SFFuVjBlYmtLWjN1NW83ZnVHU3ZBTW5zV3pidDl1ZWcw?=
 =?utf-8?B?M0t2cDB2TmJZQ3ZscGxyZUhsZS82VFFPSDYvVnlYeFlkNXh3bDhUNHpxSTdi?=
 =?utf-8?B?bHdmOVZZekZJaStwa2E5TGJtb0xUajMxUUxBcXBrRUxjUDhmRHIxd0Eya1B2?=
 =?utf-8?B?aGFqYnFjTnFZRy9wR3ZZTTFtcEFBYTgvbjljUjJGYjFyUjJ4emQrd1VIeWQv?=
 =?utf-8?B?ZGQ4Y3R5VlRZT21aS003UFZqaG5tdWxibml6Ym9KUGNMVC9yWStXTGpmRklj?=
 =?utf-8?B?SThiMWdrQk5pa2JxU3RRWEVrZjlublQzK29Pcno2SXhDUWozVUJSczZZMWMr?=
 =?utf-8?B?Mm5yQmFWOXhPQmxVTGlzdEl3ZFNNOGwvaGVnek1SWnp6MXVOSGtwRlhjUEU4?=
 =?utf-8?B?MXErZEgwRVFLQ0NMNWRXZ2NsbzUzdWdtcjMzN1JhdE1sVFFkdHAxMVg4Y25H?=
 =?utf-8?B?SS9CUWozVlZuZ1VQa21VdXF6dVJjNVNvTGovdEFEMFlWb0dWb05zSjFJK1JF?=
 =?utf-8?B?Wm55cWc5bEZqYzZ4cXFsQ1ZJRTZ3Q3lyQ1pHK01iVHZ5YVh3ZVJSRDA5UFRS?=
 =?utf-8?B?VTF4R2M1d2ZmS3AxK3ZOemo2M0VNMFFKQzJyQVM5UEtMa1FpRGExS3dyNWkz?=
 =?utf-8?B?cnZYZzdTZUsrVHlVbDZCZnQ3a3BLVVUwSit0VlZlKzEzZ1FmcXJZd2xBVFB2?=
 =?utf-8?B?UlE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	yp4L4rxTvj+Iiy37SyjY36OQ1cO6SXB+FRHAkmfXunnWfBHGbC5my/mFDoH5nFvCq27l7VgVVGkgWCJ761arNWS/ZZ2WFGXXopH6ExILOZY7azxH08WpJ0tr3c2Wr9Tij9meWSdvKF6preLvBPIYaqgR7vJup+HdFu1b3nzu7cCnzNSasy9UeVhky2oqXO8ngjXk6c5n3lk3UUOjnBoaRw3BWgGFxw0kCMAY5vxxiEMyNO51jn5/OjPoy7a1o9WBEitV38MrYyW8VEQTREv6RUlVw8KGVVc72JQw+8HAF0VW2XulQNHtFsSr2F3YGV7LXcoiuT2kL2J4Xuv5ZkGXFj/04Nv0Ixp5TiSWDEDxqzHI9usjNvBWCwkaUDEe7/8yC81EJzYJnVbcEsZ/+A/rQ88mg142+SKesxshY7+/pgTVOEgv07OBUGtj4JXjfL0RU36ZYA2vTv7btVCEHxMa6Uqj17Qeursf7Qeh9mvE3xSip++RrNzVwDAXgzK0EITNKMNlncFsijYQGWswFnoy1CAJovKpn+UR+dEXlTiu/n+mjeXiobsFsokSFGbsRoDLK0mfeTSPNCPPFpupffK6yMLHw6DOFFLOnx5TEnao7M8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fbcfed5-8c7c-4c38-9159-08dc84ea1346
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7224.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 23:00:06.2115
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e1DQ2w9BQXzxcrPIZH49G7tmHDCh9mdTzE+juIiFhrzIsYPHa4/IscgiQRsaHd5TbyArjo1/vxnkvCzMHqHD/cnmjqV/4XK8FeQDQ4l0n9I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4719
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-04_11,2024-06-04_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 bulkscore=0
 adultscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406040186
X-Proofpoint-GUID: 9_CE23UrkCgvi41thVbmCr59hCr8z_Hh
X-Proofpoint-ORIG-GUID: 9_CE23UrkCgvi41thVbmCr59hCr8z_Hh

On 6/4/24 3:36 PM, Jarkko Sakkinen wrote:
> On Tue Jun 4, 2024 at 11:31 PM EEST,  wrote:
>> On 6/4/24 11:21 AM, Jarkko Sakkinen wrote:
>>> On Fri May 31, 2024 at 4:03 AM EEST, Ross Philipson wrote:
>>>> Introduce the Secure Launch Resource Table which forms the formal
>>>> interface between the pre and post launch code.
>>>>
>>>> Signed-off-by: Ross Philipson <ross.philipson@oracle.com>
>>>
>>> If a uarch specific, I'd appreciate Intel SDM reference here so that I
>>> can look it up and compare. Like in section granularity.
>>
>> This table is meant to not be architecture specific though it can
>> contain architecture specific sub-entities. E.g. there is a TXT specific
>> table and in the future there will be an AMD and ARM one (and hopefully
>> some others). I hope that addresses what you are pointing out or maybe I
>> don't fully understand what you mean here...
> 
> At least Intel SDM has a definition of any possible architecture
> specific data structure. It is handy to also have this available
> in inline comment for any possible such structure pointing out the
> section where it is defined.

The TXT specific structure is not defined in the SDM or the TXT dev 
guide. Part of it is driven by requirements in the TXT dev guide but 
that guide does not contain implementation details.

That said, if you would like links to relevant documents in the comments 
before arch specific structures, I can add them.

Ross

> 
> BR, Jarkko