Received-SPF: pass (google.com: domain of linux-crypto+bounces-4791-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <27a0ad29-a096-48fe-b9fc-e918464227da@linux.microsoft.com>
Date: Thu, 6 Jun 2024 11:21:06 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: eahariha@linux.microsoft.com, linux-crypto@vger.kernel.org,
 linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] crypto: algif_aead: After having been compared to a NULL
 value at algif_aead.c:191, pointer 'tsgl_src' is passed as 2nd parameter in
 call to function 'crypto_aead_copy_sgl' at algif_aead.c:244, where it is
 dereferenced at algif_aead.c:85.
To: Alexander Sapozhnikov <alsp705@gmail.com>,
 Herbert Xu <herbert@gondor.apana.org.au>,
 "David S. Miller" <davem@davemloft.net>
References: <20240606172023.23-1-alsp705@gmail.com>
Content-Language: en-US
From: Easwar Hariharan <eahariha@linux.microsoft.com>
In-Reply-To: <20240606172023.23-1-alsp705@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 6/6/2024 10:20 AM, Alexander Sapozhnikov wrote:
> From: Alexandr Sapozhnikov <alsp705@gmail.com>
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Alexandr Sapozhnikov <alsp705@gmail.com>
> ---
>  crypto/algif_aead.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/crypto/algif_aead.c b/crypto/algif_aead.c
> index 42493b4..f757907 100644
> --- a/crypto/algif_aead.c
> +++ b/crypto/algif_aead.c
> @@ -191,7 +191,7 @@ static int _aead_recvmsg(struct socket *sock, struct msghdr *msg,
>  		if (tsgl_src)
>  			break;
>  	}
> -	if (processed && !tsgl_src) {
> +	if (processed || !tsgl_src) {
>  		err = -EFAULT;
>  		goto free;
>  	}


Please see
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
and format your subject line accordingly.

Thanks,
Easwar