Received-SPF: pass (google.com: domain of linux-crypto+bounces-4851-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 7 Jun 2024 18:15:16 +0200
From: Marek =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Gregory CLEMENT <gregory.clement@bootlin.com>, Arnd Bergmann
 <arnd@arndb.de>, soc@kernel.org, arm@kernel.org, Andy Shevchenko
 <andy@kernel.org>, Hans de Goede <hdegoede@redhat.com>, Ilpo
 =?UTF-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>, Olivia Mackall
 <olivia@selenic.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 linux-crypto@vger.kernel.org
Subject: Re: [PATCH v11 6/8] platform: cznic: turris-omnia-mcu: Add support
 for MCU provided TRNG
Message-ID: <20240607181516.72edb60a@dellmb>
In-Reply-To: <ZmLhQBdmg613KdET@gondor.apana.org.au>
References: <20240605161851.13911-1-kabel@kernel.org>
	<20240605161851.13911-7-kabel@kernel.org>
	<ZmLhQBdmg613KdET@gondor.apana.org.au>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, 7 Jun 2024 18:30:24 +0800
Herbert Xu <herbert@gondor.apana.org.au> wrote:

> On Wed, Jun 05, 2024 at 06:18:49PM +0200, Marek Beh=C3=BAn wrote:
> >
> > +static int omnia_trng_read(struct hwrng *rng, void *data, size_t max, =
bool wait)
> > +{
> > +	struct omnia_mcu *mcu =3D (struct omnia_mcu *)rng->priv; =20
>=20
> Please don't cast rng->priv in this manner.  Please take a look at
> drivers/char/hw_random/bcm2835-rng.c for how it should be done.
>=20
> Thanks,

THX, prepared for next version.