Received-SPF: pass (google.com: domain of linux-crypto+bounces-4859-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: JiaJie Ho <jiajie.ho@starfivetech.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
CC: "David S . Miller" <davem@davemloft.net>, "linux-crypto@vger.kernel.org"
	<linux-crypto@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] crypto: starfive - Align rsa input data to 32-bit
Thread-Topic: [PATCH] crypto: starfive - Align rsa input data to 32-bit
Thread-Index: AQHasV7JGIR2o9Gsw0quf+yEyIC5HbG8Na+AgASvG1A=
Date: Mon, 10 Jun 2024 10:50:14 +0000
Message-ID:
 <NT0PR01MB1182521792A1CB004CB525648AC62@NT0PR01MB1182.CHNPR01.prod.partner.outlook.cn>
References: <20240529002553.1372257-1-jiajie.ho@starfivetech.com>
 <ZmLsK9Apy9NwNEQi@gondor.apana.org.au>
In-Reply-To: <ZmLsK9Apy9NwNEQi@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?SgOQ/NBo2DlQTtfBo22E3i0x8e4r7XND6Bnhy13FKxOQ0MZSRG/tg4ONBgPp?=
 =?us-ascii?Q?B8/TrCbkj/9U0PoDKq3LcnITXYrExW9cH5XSyG4jasJ36VlymYH+H0/4ItUi?=
 =?us-ascii?Q?24eIuoN7zo01P6DSCFpWFKrCejRUsvGEFVzyTIazxqGBUE7dK+2YvwOqcQJ3?=
 =?us-ascii?Q?smCPtyqyCklTPKfSzctjanFzozOiayIyoAsfuW653WyeQB4Bb1paBeq0v+0M?=
 =?us-ascii?Q?IvxDqo7LX8bVtORldrcgtpfYsJ4p1x+dVvkQBTf4r3p9AD5vEF08h0tJJu0w?=
 =?us-ascii?Q?BL+Xp12KEGUD2iBDNHXRNbYVRfHMsSveLv1rM8aUNfep4cXBXeZd+g78RHHU?=
 =?us-ascii?Q?maqZ9SZa7blBD1GjYOVwZEaT7qt8jhez6e1qK8yba+HJ+d+a0qZiWIEF5fPf?=
 =?us-ascii?Q?az01+26dQJqtCUp4T7vC/xEgqeAuBCFGJos5J+vyIIvPo4ektV8YegEOIdEY?=
 =?us-ascii?Q?AcuuRW2r1KIXTt4IdpiOONmO75Of4q8m2sdm/99Ofvn1AVqwOYa2Xl3zwkxZ?=
 =?us-ascii?Q?EQrWGyDeDe1JGzFzE/kCSSBAwrjN4LSoSmzFFH37Z1A+M3Fuj0gZHJu+2xL7?=
 =?us-ascii?Q?rqbMx3/86tkrDr0BUDkzva9hhN5g4WTuaOHyEt87kehM8ZsOixN3VBJvWM8B?=
 =?us-ascii?Q?OsRvcp/DdT93OUjp02yLh6HoexKS8wGofIfjzHMMC94BQaKsaqxu5tiB53uh?=
 =?us-ascii?Q?MJ4I01NTtYQ/++Z3S1INkZTyuGi4248zhko2pIZ1k+iviFelUsphv+ipqiZT?=
 =?us-ascii?Q?o/uxbiatYkU+8kuaPOB6QzL+Lz1luL1Dyl11VjAWjMkALoYxWtGhVCuCShmD?=
 =?us-ascii?Q?rr38OiTrqB9c/+c8zGGdhYjZMGLiJGCslfWEhvdlhAhBbSM7BYjmhis9RF0r?=
 =?us-ascii?Q?MXF138tvcGt9ZsLuWWvXs3GtuR5WfEBij5aJqQCGMLL1EfTNsGzgj+QFWqyb?=
 =?us-ascii?Q?3vqmHZ/XZQSlLafbrJZz+wT6c7xSxi+mKLRxo+7mOpJO7q8EMl1wzj5BERiU?=
 =?us-ascii?Q?RvR7TEByomJwiGy8nR+Wf7nN8BnIwV5fkn3qOZNclmyaAJgxe8ZmIX+WWIGa?=
 =?us-ascii?Q?dbFaH6seQUzixLfbVwdj48hBefYXfISSugqr34h5PnTpFail+jiDFiond38k?=
 =?us-ascii?Q?rye9NYOkAIpTVyj5ThghYTwfMDX6nbTsWQ5SxziEoznDhIjP6A7M8750X0Lc?=
 =?us-ascii?Q?uyhOzrLsP4HiyycLpb3DY0DOcdndtgqanYRwKp9G73VCw5RiBKGC/+8F3o9m?=
 =?us-ascii?Q?7rMGpMC6D1Xa0msCy13kr3hZQHTZSc4pXPrlpWrVXwlf6GYYtcc3xv0261jA?=
 =?us-ascii?Q?4QZdT2yy/P0gyZA2agLr6PwewwclZVrAJ6qKWwtHjpYRWAP5iKFiH7E6ahs3?=
 =?us-ascii?Q?YW4WZ4uBQWtjuArLLLDrBfw1LTeQsD4daf7RwfgXd1v0HajiQWSwL9bpsI1j?=
 =?us-ascii?Q?jyrMJCjMp/d9tYp4UiVD/GURYlKZHoc0X3j1PPhmmlnFyqSRctRySzgKsbYo?=
 =?us-ascii?Q?4G+t/3jagwyAXbLFbws8b63Kmmx+auLbvRNcnSnLai4PFLe15vTUwC9o5X26?=
 =?us-ascii?Q?aJwDtxdyDUE8FlervRIGZT9GQnn2pfwF6cVGtJo20/eYo6Womb0Chbq+RcMf?=
 =?us-ascii?Q?4g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-crypto@vger.kernel.org
List-Id: <linux-crypto.vger.kernel.org>
List-Subscribe: <mailto:linux-crypto+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-crypto+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: starfivetech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: NT0PR01MB1182.CHNPR01.prod.partner.outlook.cn
X-MS-Exchange-CrossTenant-Network-Message-Id: d402d2ea-b383-49a7-5eb3-08dc893b1be8
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2024 10:50:14.3850
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 06fe3fa3-1221-43d3-861b-5a4ee687a85c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YiIdxS/iQWCwd3mFZ3taeGRyS63rIw+xu/gRYMZmWvqTo6BrrxWXtIoDGZxVd+RqFYc7GcNvCoqvdWURw2v3styNPw/TkQSW+VxNb1/meGQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: NT0PR01MB1152

> On Wed, May 29, 2024 at 08:25:53AM +0800, Jia Jie Ho wrote:
> > Hardware expects RSA input plain/ciphertext to be 32-bit aligned.
> > Allocate aligned buffer and shift data accordingly.
> >
> > Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
> > ---
> >  drivers/crypto/starfive/jh7110-cryp.h |  3 +--
> > drivers/crypto/starfive/jh7110-rsa.c  | 17 ++++++++++-------
> >  2 files changed, 11 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/crypto/starfive/jh7110-cryp.h
> > b/drivers/crypto/starfive/jh7110-cryp.h
> > index 494a74f52706..eeb4e2b9655f 100644
> > --- a/drivers/crypto/starfive/jh7110-cryp.h
> > +++ b/drivers/crypto/starfive/jh7110-cryp.h
> > @@ -217,12 +217,11 @@ struct starfive_cryp_request_ctx {
> >  	struct scatterlist			*out_sg;
> >  	struct ahash_request			ahash_fbk_req;
> >  	size_t					total;
> > -	size_t					nents;
> >  	unsigned int				blksize;
> >  	unsigned int				digsize;
> >  	unsigned long				in_sg_len;
> >  	unsigned char				*adata;
> > -	u8 rsa_data[] __aligned(sizeof(u32));
> > +	u8					*rsa_data;
>=20
> You didn't explain why this is moving from a pre-allocated buffer to one =
that's
> allocated on the run.  It would appear that there is no reason why you ca=
n't
> build the extra space used for shifting into reqsize.
>=20

I'll update this in the next version.
Thanks for reviewing this.

Best regards,
Jia Jie