Received-SPF: pass (google.com: domain of linux-crypto+bounces-4892-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 11 Jun 2024 12:23:59 +0100
From: "Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>
To: Chen Ni <nichen@iscas.ac.cn>
CC: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
	<markas.rapoportas@intel.com>, <ahsan.atta@intel.com>,
	<mun.chun.yep@intel.com>, <xin.zeng@intel.com>, <qat-linux@intel.com>,
	<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: qat - add check for adf_cfg_add_key_value_param
Message-ID: <Zmgzz98P24EU/p9y@gcabiddu-mobl.ger.corp.intel.com>
References: <20240605031835.2916052-1-nichen@iscas.ac.cn>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240605031835.2916052-1-nichen@iscas.ac.cn>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mVOjeDIRIhmVe9JJjBUJ26fgqSle2uyLERMwSpJq6bRpdSLpmF/ZBTznjisI?=
 =?us-ascii?Q?th25uugv7O86InYkOT+C1ChywK4aB6CPFBTJTcCE3e60ALY76DAm0KXU7UQx?=
 =?us-ascii?Q?i9xgbfbyeKRh399bjaoZoE4JVcx2S0K/SpwGBJry/QBmReCeSCej3GAwaoMC?=
 =?us-ascii?Q?bSwnV2EodE5RdnpMmMq3pNgnCdc5wI1RV8Z5+vMtVgxEGpjh3XJd2THAYe9s?=
 =?us-ascii?Q?U2937eMV55WTriYVbMt9lRoVcvPnvQNJiBVEeMfWcV8ZANSy9A+CPOH6xd1D?=
 =?us-ascii?Q?NkQVm76MmoPCfFAgshNYv2qzLouh9d1n9QXFbUdyPVWe1EacKUUpF57IlSHe?=
 =?us-ascii?Q?ZtPG2KmBz51O6VTcjc7JM9AjbWXMwmyAZJhpOGiyhJJ1EmPU6mOswNY+XY7a?=
 =?us-ascii?Q?HHsi+idE8CpvmGl2oGeV12Xx9lp4I9/tvxnywPYVJI4YXmOHp+bOveWWLg4S?=
 =?us-ascii?Q?/CnP2XVF9iYRaOpBzLcA7ikp5VLSyLp8pW9N1YSYnEBe8bU8XraGEJKA8Kw2?=
 =?us-ascii?Q?YlqYHymdQqNS0KeKTelVVs3XwYJ1t9U2QuvqntD+ZBAM9lygV3a10pDMRyMY?=
 =?us-ascii?Q?zKZBU4IXqTbXvp7KJLHWgh1buFiLZsP9tyMTVg7yLgeG3NsSCQnDhNNV6aQM?=
 =?us-ascii?Q?Lnrcalbe3NVb9JbO/SBFbM36F34vCNKjB1u565yJLTj4R5wQOogjazBrwPw6?=
 =?us-ascii?Q?I+puihwvI7fCc/99ZB7bnmLssIG6SXwRn6ttvC6pUsMcZIv1BsqWyNYVmstJ?=
 =?us-ascii?Q?LECWc/GrZ0ZhdyGIO8v4irxl06otKqohB3ndjgMb8v/URpE+TCw/mOorVddI?=
 =?us-ascii?Q?wr4PJ2XsumvGGuWOjYbncCUXErFud5Q8zqEh6PKIBDMTTTLvVtkdnS4ihnnQ?=
 =?us-ascii?Q?Z1YZcfRN9NgKh+EcQ1sAwXsLWpmeSL8zA+7VaM7tSYqaUfSDG+Opd9xy71Mn?=
 =?us-ascii?Q?Vo7ZU7qInMmfhj5ldhh731k/1Wfh66FsTyus5EEEAjkvTQ8rbAm2nDUnDJkJ?=
 =?us-ascii?Q?wourDhr6BTN6WoRDr0oVYjwnu3PQxsGHxyW2xql5ng5ZgQrBN3My+Wanxxxm?=
 =?us-ascii?Q?sBVy0e7Kj7ulKaOA63Gbb+9Qf+CG+CFmnRWC40j0BDcfXIygF999coRltCcl?=
 =?us-ascii?Q?cHeH1udCGgnQLcA+E6mDjsqtxoOeT7xoP60dXXDfE2H2/6O3n4PI3CMlpjW0?=
 =?us-ascii?Q?6C8UhzuXZrB+3Ubvu3wHJoiN9GOevEQDbgC60bKuETEjC/fifgB4KlOtm+5f?=
 =?us-ascii?Q?RT4R9iL3HFMsYG2A4RsSiTaudTK0CUY1PMpKRwC9c/34OyEtcABComG+jWCK?=
 =?us-ascii?Q?QrQm/P+BWyxosIk6zYdmnZjHhib3u61azxzd/DKeSpJJF0UQMjklz+Ux5Smt?=
 =?us-ascii?Q?A2JMlZ9Lo9VMXloUAejuul3zG6R0ky2jqSQtWo6qdSHpu3297SfK3hXgNuAI?=
 =?us-ascii?Q?tmbZXC/OCx+p1mgUxxeFxi1IwL2aFxKP77U5i1yr4z7bPSIfJlv8N2RZwpUn?=
 =?us-ascii?Q?cG+NYnYYUZIVM5T+8uCAw+1j1na7YOefQyAMk11oiz2dvIIiihYSmWSQS18C?=
 =?us-ascii?Q?vOqAYR3az2TK17ebhNHxj+uKwBkJgTMh5p6N1lfiU9roRCWC2n9XBoQ5Rn1B?=
 =?us-ascii?Q?oQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e199fb1e-d255-4923-35c8-08dc8a0901af
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 11:24:06.8718
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Dk+2BcA/w7OmizLGeWm57Uczxr93qXKEn46s4JCnkSBMgr6jEmo72bs1qBoqfFHClEVfojM4wJszq7MNcuutLu1mfkLt5VRMl+K2jFMTUGs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4537
X-OriginatorOrg: intel.com

On Wed, Jun 05, 2024 at 11:18:35AM +0800, Chen Ni wrote:
> Add check for the return value of adf_cfg_add_key_value_param() and
> return the error if it fails in order to catch the error.
> 
> Fixes: 4469f9b23468 ("crypto: qat - re-enable sriov after pf reset")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/crypto/intel/qat/qat_common/adf_sriov.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/intel/qat/qat_common/adf_sriov.c b/drivers/crypto/intel/qat/qat_common/adf_sriov.c
> index 8d645e7e04aa..30ff9097f527 100644
> --- a/drivers/crypto/intel/qat/qat_common/adf_sriov.c
> +++ b/drivers/crypto/intel/qat/qat_common/adf_sriov.c
> @@ -228,8 +228,10 @@ int adf_sriov_configure(struct pci_dev *pdev, int numvfs)
>  		return ret;
>  
>  	val = 1;
> -	adf_cfg_add_key_value_param(accel_dev, ADF_GENERAL_SEC, ADF_SRIOV_ENABLED,
> +	ret = adf_cfg_add_key_value_param(accel_dev, ADF_GENERAL_SEC, ADF_SRIOV_ENABLED,
>  				    &val, ADF_DEC);
> +	if (ret)
> +		return ret;
This has the side effect of failing the enablement of VFs for QAT GEN2 as
ADF_GENERAL_SEC is not present.

For GEN4, where ADF_GENERAL_SEC is used, if this function fails, the recovery
paths is not going to re-enable SRIOV VFs after reset.
It is ok to omit this check.

Regards,

-- 
Giovanni