Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp516015lqp; Tue, 11 Jun 2024 10:51:00 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXUbykFrV/VaBG2/YXq8FLvhDRQ1eGN36Su3lKQ0XAKGJgVtZyuLE0tIf7phcOv4djOZtWvnaHlDsl2k1jcEkQElXGk0pi+LuV5jolrIA== X-Google-Smtp-Source: AGHT+IF03WOjfOpmICdaYrKnFsXMvITyM6/c7bdTK1x/WBzLAQ/iJVPXKVCMAP5F420YFvREHxyN X-Received: by 2002:a05:622a:490:b0:43f:ee9d:c2ce with SMTP id d75a77b69052e-44041cded30mr165354291cf.45.1718128260023; Tue, 11 Jun 2024 10:51:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718128260; cv=pass; d=google.com; s=arc-20160816; b=S4vVHXPrCLALDf9CJz1yz6oqnsawxJmtzJDPxyOO+Hcss+6sQqzI8MtSWIKhM8MgzS yLgcg7tFRslBctE1LMPX2AVDWOtxJBS2WRlUxGFSwUm6FxqSYsdIuVf5/yr5g+EdQ/13 E/o90+FVXZB0avYgHGb4ctfw+g92siKVXmvMStdib7VtQm5NIgKWdqvN7sQSYliOAYv7 5sfb6TF016Z+a95juHwY8gBFzcfWA40lfjo91I31LMeIeBft+AnhkDsvFr1XTUwzhcM/ zJlLVfJuRU0k/6f0VF7tYhOm/FKBnRCqVSjwkhWKCZ1v8pwvt/ph6fyalgSEBL3Jcm4P Z0Tg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=x3d8v6pZhXdUutSOPHuf5Yykli9QyJ0SUOeYLR4UNjU=; fh=3TkOvPj4pJTu7VDeA58L2wg1w00Z6sJ0cTOL+LiTlkk=; b=tgKRFdQmUH5jmW5HVne2BfiRGgREDVKtoNeEO0UYHmLjZLJwWfCBV5G2fZN4fvn0iz hb1bdiSvxbDIMC1M95LiVrPBBMv9VevixbhUS/PBa3mlnlSIYsbgT/yuOS4BNFO+Nr5C fisRJnOYLcbWU5OOUhHTwbb+wUisURieMVSeAc0MCMVIFhtDz6W59T/hJizNgxxI8Trn Aw2ooIkkhPe9UgG20FPIOQ5u+hSPp1DOWgodW2rUkCPBbhzuit/OTJe5d+xy11tOLMVh Y2K3/mDJEL8EusWUzdDfpt6wk5ObdTM04+fHinxXmBCkpwhHjEBfFWD6znu7w7hozV45 gK4w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="iQzWn/Sz"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-crypto+bounces-4901-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-crypto+bounces-4901-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-440547d3103si104095931cf.55.2024.06.11.10.50.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 10:51:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto+bounces-4901-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="iQzWn/Sz"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-crypto+bounces-4901-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-crypto+bounces-4901-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7A0AB1C23C4D for ; Tue, 11 Jun 2024 17:50:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E91EE53E15; Tue, 11 Jun 2024 17:50:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iQzWn/Sz" X-Original-To: linux-crypto@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EF6C2570; Tue, 11 Jun 2024 17:50:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718128254; cv=none; b=WRA/K//Ajnxqf9NRZ0fPFVleolnU5t150dwibZpbzALaLlXSyFW7O9yPgXHSGOiWJ1PEVDmfvi/bnRWY4kze03P0OG6HP9avRaLnb0YIIt3bTpjew4lLgNmehsVZ/EmH9Zx7mG28kLlZ0m2G9wwm4hB1DZH86yLnEG9RvepzigM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718128254; c=relaxed/simple; bh=qKv99FKq5QNiYusY4oaFndG2yZprCcFJ9vJUSneVSVI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CBST5OVuHt1XvMUe3JU96rmI7pOYZN+Sz8WUZMDa6UWlAZtbsUQ/igtrzauA1PTgxoLKtRhKK4ZA99GX/YgkdgFeYtefoplzZxv6ss8nYrYTR6vzTEqCxnRDlnSG6C9AL67dWHftUcln/VV/uLB6nt3xSzw3i+ptvqZ0zrFaPQU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iQzWn/Sz; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1231C2BD10; Tue, 11 Jun 2024 17:50:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718128254; bh=qKv99FKq5QNiYusY4oaFndG2yZprCcFJ9vJUSneVSVI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iQzWn/Szpxmn6IF3SVEGpR/idtK+mB1QyIjeo5PocwfeNLjhOcfzIxLqvEf7dJXEE PPmVfbALE3Mv6mbE60zRJPK9pNuOngcII5X7EeqYT2mIEdZMbHXwXdbvEGBLRMEHD9 yEw3g6c2/WwoMrPnUqHUMZ/Zlkkpyxabgo1C/KMhpGD3s883jbAGPeCM6tyAoY03om VMf7OrxrBIFigNEJNSY/k33Or2dNaJpgbsTDZ1qCnvXgN319rXuQ7Jzo+OUmvHMmgn JfowyGDbznZEfZiPWpG00/z4tNRZrEazAy2ROET7Icl1DfXr8PkTR7yvSYVDZESKgm 3lnr9p9kawGJg== Date: Tue, 11 Jun 2024 23:20:50 +0530 From: Vinod Koul To: Jia Jie Ho Cc: Herbert Xu , "David S . Miller" , Eugeniy Paltsev , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [PATCH v5 1/3] dmaengine: dw-axi-dmac: Support hardware quirks Message-ID: References: <20240530031112.4952-1-jiajie.ho@starfivetech.com> <20240530031112.4952-2-jiajie.ho@starfivetech.com> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240530031112.4952-2-jiajie.ho@starfivetech.com> On 30-05-24, 11:11, Jia Jie Ho wrote: > + > +struct dw_axi_peripheral_config { > +#define DWAXIDMAC_STARFIVE_SM_ALGO BIT(0) what does this quirk mean? > + u32 quirks; Can you explain why you need this to be exposed. I would prefer we use existing interfaces and not define a new one... -- ~Vinod