Received-SPF: pass (google.com: domain of linux-crypto+bounces-4905-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240610152638.2755370-2-ardb+git@google.com>
In-Reply-To: <20240610152638.2755370-2-ardb+git@google.com>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Tue, 11 Jun 2024 23:10:22 +0200
Message-ID: <CACRpkdbc5ENohiFg4_mEfYk8A74UG2hiECCDfELnMu7ghKa3Ww@mail.gmail.com>
Subject: Re: [PATCH] crypto: arm/crc32 - add kCFI annotations to asm routines
To: Ard Biesheuvel <ardb+git@google.com>
Cc: linux-crypto@vger.kernel.org, linux-hardening@vger.kernel.org, 
	herbert@gondor.apana.org.au, Ard Biesheuvel <ardb@kernel.org>, 
	Kees Cook <keescook@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 10, 2024 at 5:26=E2=80=AFPM Ard Biesheuvel <ardb+git@google.com=
> wrote:

> From: Ard Biesheuvel <ardb@kernel.org>
>
> The crc32/crc32c implementations using the scalar CRC32 instructions are
> accessed via indirect calls, and so they must be annotated with type ids
> in order to execute correctly when kCFI is enabled.
>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>

Fixes: 1a4fec49efe5 ("ARM: 9392/2: Support CLANG CFI")
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Thanks for helping to iron out the rough corners on these patches!

Yours,
Linus Walleij