Received-SPF: pass (google.com: domain of linux-crypto+bounces-4923-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Jonathan Corbet <corbet@lwn.net>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>, Dan Williams
 <dan.j.williams@intel.com>, Herbert Xu <herbert@gondor.apana.org.au>,
 "David S. Miller" <davem@davemloft.net>, Andre Noll <maan@systemlinux.org>
Cc: linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, kernel@pengutronix.de, Ahmad Fatoum
 <a.fatoum@pengutronix.de>
Subject: Re: [PATCH v2] docs: crypto: async-tx-api: fix broken code example
In-Reply-To: <20240529-async-dma-docs-v2-1-8faf87e72e6d@pengutronix.de>
References: <20240529-async-dma-docs-v2-1-8faf87e72e6d@pengutronix.de>
Date: Wed, 12 Jun 2024 15:41:04 -0600
Message-ID: <87cyolon4f.fsf@trenco.lwn.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Ahmad Fatoum <a.fatoum@pengutronix.de> writes:

> The code example fails to compile:
>
>   1) addr_conv is defined twice, once as a VLA, which have been phased out
>
>   2) submit is not a pointer, but is still dereferenced with ->
>
>   3) The first call to async_xor() lacked the trailing semicolon
>
> Fix these issues and while at it, fix some code style nitpicks as well:
>
>   1) make the functions static as users are unlikely to export them
>
>   2) include the relevant header
>
>   3) Shorten the example a bit by removing a redundant variable
>      definition
>
> Fixes: 04ce9ab385dc ("async_xor: permit callers to pass in a 'dma/page scribble' region")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

It looks like nobody has picked this up, so I've applied it.

Thanks,

jon