Received-SPF: pass (google.com: domain of linux-crypto+bounces-4940-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 14 Jun 2024 14:33:20 -0500
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
CC: <linux-modules@vger.kernel.org>, Luis Chamberlain <mcgrof@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	<linux-kernel@vger.kernel.org>, Herbert Xu <herbert@gondor.apana.org.au>,
	<linux-crypto@vger.kernel.org>
Subject: Re: is_module()
Message-ID: <yzxjbx7c3hzodikhaeuv6k4ypxz22kxldfiwsl6gshderomw5e@j2jgdqb6jlf5>
References: <D1H452IHSLRC.1WZSPJQLCD5RD@kernel.org>
Content-Type: text/plain; charset="us-ascii"; format=flowed
Content-Disposition: inline
In-Reply-To: <D1H452IHSLRC.1WZSPJQLCD5RD@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FXBG2dnmz0qYL2rUecC/6usQxQ0wMgpjr9XYG9OoGrId2IREW0/vsrgH1cG8?=
 =?us-ascii?Q?hs5M+jcJ/B98uqxcaUEy40fY4KY3X5yn2QeXdm5ZXvKfKMZEAR8Y6nRb6Nmj?=
 =?us-ascii?Q?GVStHGzjhqkTTbLq583+sKXXCvK7EXsuih6/B9/a2EaR1WsmDlfdWCmGkNWv?=
 =?us-ascii?Q?Sapwq6YqODXpN6zakhcpMm7yN2QZ4TnwbvHA4wjzRwTl8auIFL084sVAFwRg?=
 =?us-ascii?Q?PboztSElDptIqYFd63N/5TWdkITup5fAue4fEXgLDk2+fBgpKSa6/5RqVV8k?=
 =?us-ascii?Q?ys5nVVSTScpntwX19a1+q1EfCq826eV9DdfS9ULMf9BnttxxUueQzdc9f8j7?=
 =?us-ascii?Q?DD75wxnSydQXtqy2dkwPyStiQjNqrFkPL+wuLUHRnXEhSq/rjTmNkJdHBNgS?=
 =?us-ascii?Q?TkzlD/8/I5XhL0gGlbf9Xsvw2sysuAePJn4azCrQvSuG87JtIJmX4hxBurlz?=
 =?us-ascii?Q?K4S1nlF6LAwMjVZ3xATfpQAWm/iuCqS1LlU4HCIOj0n9fPdjNvZZ5hxz4nlC?=
 =?us-ascii?Q?FDb8QYBsMRcSb0c9Ufz9S1gdZr2POSGKSmZcvUtoZSJEDRF6G6fn+6sJJC6n?=
 =?us-ascii?Q?9y2FjioA/t4NhM83J+p239yH6uwQQ3Fup/gDc0BaotIKvButOU9XKL4TC4NL?=
 =?us-ascii?Q?rZyL0uQNkXwoZw6VAfnnfUk7p3aGd7sNQmPbXzIjJJplqmI0xq0gKgs97nCv?=
 =?us-ascii?Q?87ithfUuIALuBGa5iEUIZcs0oK2zrVt/iyxmHZZzaO6NQvtzRbb2EPHALeMi?=
 =?us-ascii?Q?875rJSWnSxYwqn2q66PC6oCUr2ZueiU9BoEGi4xdVcTiysE/ubJPhP+ixATi?=
 =?us-ascii?Q?QEZqU4b39vr0dTihAVL21MzBoXH90lS6LdoLuuWlO6iXw2imykQynbOel0T8?=
 =?us-ascii?Q?wfj4lqRltREP+CTzeukQbsd7azjtx8q/u5qzKV7lZj5n6oFrUTks2xBDn5kv?=
 =?us-ascii?Q?OQgFqSvcIB9yQMJ0kUKB0UieHSVz1IuId3uc8WgF8TKowerjyCKxUKV724px?=
 =?us-ascii?Q?WWKVVVGoXK/hZ/NldvnxtZFhOheXoc7VAOv35B0ggGz7/B1ZJ02PgWJWtfNo?=
 =?us-ascii?Q?oM8ASEX6W0dubyYXc52REy9mNn+AOdvU2Tuerty1gbo066vCHrFnXx5i7PhT?=
 =?us-ascii?Q?bXp7iy3RvrqSyn5nkZ96nqRT59GpeDoF1vKCuOXgimJjGd4fU3vgIJp9fsiC?=
 =?us-ascii?Q?PhqYTIkA7FmDPk8XkKpdvAobHd658Zv8CWNXOAWoAMCsdaHs7xaVZS7llNDn?=
 =?us-ascii?Q?BQfsveFuIRM7XlcUIb+ol9cJVT2iyuhSnVTIBY3RIAwVQAeq9u4qN0zmvXsA?=
 =?us-ascii?Q?NGbeIhbLl0JISvzCouiBcEV//kgaEZJvWupeqRTjnJWgfvu54t4jKqxlH3er?=
 =?us-ascii?Q?cW8txwZg7ORpESmQimeNPkGl8Lr0TOQff+JOvb5cuZwGeJJefn7BRJduUx+M?=
 =?us-ascii?Q?axA30d6ULcTQZVXRyv2wKdAlPCaofcsUC7K01YGHRN2A7JD+XeKY9Zto+8D+?=
 =?us-ascii?Q?cywZ8FBll81nu3udR7POoaBFZq4NCFLj/D9C+PTk++flDQ1VjOAfz7KFQZeg?=
 =?us-ascii?Q?1NdNYwi5ifEl/ZUMZyFbJ0EoBFMpujPaYnXRZVUijotcZb3VmjjdepqgazUV?=
 =?us-ascii?Q?aA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 98caca06-bf9b-4d51-4bfe-08dc8ca8dcc1
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 19:33:27.2330
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dfTQe6HQCqOufp84jEIeUL09LGG0yz9eNtp4wyWlVjRxShVpnxeUkwpMhHHpLutknLTFN8EtzjVptd0ay03WMBw1bxs/rZ0HH5P+3qhqIyo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6896
X-OriginatorOrg: intel.com

On Thu, May 23, 2024 at 06:01:49PM GMT, Jarkko Sakkinen wrote:
>Hi,
>
>I just put this here while I still have it on my mind. Possibly I'm
>ignoring something that already enables this but at least I learn
>something by doing this then.
>
>This came up in a recent discussion albeit for this crypto bug it
>did not make waves because the bug fix did not require it:
>
>https://lore.kernel.org/linux-integrity/D1GXKODMD4S8.1J12D4GOEQWPL@kernel.org/
>
>So the gist of  is_module() would be that it would have different
>semantics than IS_MODULE(): it could be used to e.g. check modules in a
>loop.
>
>Compilation would generate a new ELF section with following entries:
>
><ASCIIZ string><0 or 1>
>
>The string would contain module name, and 1 could be marking for
>being a module, and 0 for being builtin.
>
>Also, it would enabled to add lsmod -b to enumerate built-in modules,
>which would give nice way to carve up more information about a running
>test kernel. This would obviously need perhaps a new file to procfs for
>built-in modules (for regular there is /proc/modules).


this information is already exported by kernel's build system:

$ head  /usr/lib/modules/$(uname -r)/modules.builtin
kernel/arch/x86/kernel/msr.ko
kernel/arch/x86/kernel/cpuid.ko
kernel/arch/x86/platform/intel/iosf_mbi.ko
kernel/kernel/configs.ko
kernel/mm/zbud.ko
kernel/mm/zsmalloc.ko
kernel/mm/z3fold.ko
kernel/fs/binfmt_misc.ko
kernel/fs/binfmt_script.ko
kernel/fs/configfs/configfs.ko

But I'm not sure if you were intendending to use that inside the kernel
as per the other thread you mentioned.

libkmod uses the more verbose  modules.builtin.modinfo
so e.g. `modinfo ext4` works even if ext4 is builtin.

We indeed miss a -b flag to lsmod, but that would be an welcome
addition.  A decade or so ago I was thinking to actually use
/sys/module/ to get details about builtin modules. At the time
we didn't have modules.builtin. However not all builtin modules
create a dir in /sys, only the ones that have module parameters. I was
surprised it's still in kmod's TODO file:
https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git/tree/TODO#n56


Lucas De Marchi

>
>Not fighting for having this, just makig it visible.
>
>BR, Jarkko