2007-12-16 17:59:28

by Tan Swee Heng

[permalink] [raw]
Subject: [PATCH 1/2] Renamed salsa20_32.c to salsa20_glue.c

The salsa20_32.c file is renamed to salsa20_glue.c. This is done
because the code is essentially the same "glue" code needed for the
x86-64 version. It makes sense to combine them as one.

Signed-off-by: Tan Swee Heng <[email protected]>


Attachments:
(No filename) (242.00 B)
0001-Renamed-salsa20_32.c-to-salsa20_glue.c.txt (8.58 kB)
Download all attachments
Subject: Re: [PATCH 1/2] Renamed salsa20_32.c to salsa20_glue.c

* Tan Swee Heng | 2007-12-17 01:59:26 [+0800]:

>The salsa20_32.c file is renamed to salsa20_glue.c. This is done
git-format-patch -M produces a smaller patch because it can detect
renames. Just a note for the future :)

>diff --git a/arch/x86/crypto/salsa20_glue.c b/arch/x86/crypto/salsa20_glue.c
>new file mode 100644
>index 0000000..8592ccb
>--- /dev/null
>+++ b/arch/x86/crypto/salsa20_glue.c

>+static struct crypto_alg alg = {
>+ .cra_name = "salsa20",
>+ .cra_driver_name = "salsa20-asm",

>+MODULE_ALIAS("salsa20");

I guess Herbert wants to see here a
MODULE_ALIAS("salsa20-asm");
here as well.

2007-12-17 16:01:40

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH 1/2] Renamed salsa20_32.c to salsa20_glue.c

On Sun, Dec 16, 2007 at 08:53:10PM +0100, Sebastian Siewior wrote:
> * Tan Swee Heng | 2007-12-17 01:59:26 [+0800]:
>
> >The salsa20_32.c file is renamed to salsa20_glue.c. This is done

Patch applied. Thanks!

> >diff --git a/arch/x86/crypto/salsa20_glue.c b/arch/x86/crypto/salsa20_glue.c
> >new file mode 100644
> >index 0000000..8592ccb
> >--- /dev/null
> >+++ b/arch/x86/crypto/salsa20_glue.c
>
> >+static struct crypto_alg alg = {
> >+ .cra_name = "salsa20",
> >+ .cra_driver_name = "salsa20-asm",
>
> >+MODULE_ALIAS("salsa20");
>
> I guess Herbert wants to see here a
> MODULE_ALIAS("salsa20-asm");
> here as well.

I've added that too.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt