Subject: [RFC] [crypto] AES shorten the Kconfig entry

Remove copied / duplicate entry from the assemble version and add a
small hint that the assembly version performs better and is not
a relict.

Signed-off-by: Sebastian Siewior <[email protected]>
---
crypto/Kconfig | 39 ++++++---------------------------------
1 files changed, 6 insertions(+), 33 deletions(-)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 864456c..9be60a4 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -320,47 +320,20 @@ config CRYPTO_AES

config CRYPTO_AES_586
tristate "AES cipher algorithms (i586)"
- depends on (X86 || UML_X86) && !64BIT
+ depends on (X86 || UML_X86) && !64BIT && CRYPTO_AES
select CRYPTO_ALGAPI
- select CRYPTO_AES
help
- AES cipher algorithms (FIPS-197). AES uses the Rijndael
- algorithm.
+ This is the assembly optimized version of AES. It should perform better
+ than the generic implementation above.

- Rijndael appears to be consistently a very good performer in
- both hardware and software across a wide range of computing
- environments regardless of its use in feedback or non-feedback
- modes. Its key setup time is excellent, and its key agility is
- good. Rijndael's very low memory requirements make it very well
- suited for restricted-space environments, in which it also
- demonstrates excellent performance. Rijndael's operations are
- among the easiest to defend against power and timing attacks.
-
- The AES specifies three key sizes: 128, 192 and 256 bits
-
- See <http://csrc.nist.gov/encryption/aes/> for more information.

config CRYPTO_AES_X86_64
tristate "AES cipher algorithms (x86_64)"
- depends on (X86 || UML_X86) && 64BIT
+ depends on (X86 || UML_X86) && 64BIT && CRYPTO_AES
select CRYPTO_ALGAPI
- select CRYPTO_AES
help
- AES cipher algorithms (FIPS-197). AES uses the Rijndael
- algorithm.
-
- Rijndael appears to be consistently a very good performer in
- both hardware and software across a wide range of computing
- environments regardless of its use in feedback or non-feedback
- modes. Its key setup time is excellent, and its key agility is
- good. Rijndael's very low memory requirements make it very well
- suited for restricted-space environments, in which it also
- demonstrates excellent performance. Rijndael's operations are
- among the easiest to defend against power and timing attacks.
-
- The AES specifies three key sizes: 128, 192 and 256 bits


2008-04-05 13:07:29

by Herbert Xu

[permalink] [raw]
Subject: Re: [RFC] [crypto] AES shorten the Kconfig entry

On Fri, Mar 28, 2008 at 11:39:52PM +0100, Sebastian Siewior wrote:
> Remove copied / duplicate entry from the assemble version and add a
> small hint that the assembly version performs better and is not
> a relict.
>
> Signed-off-by: Sebastian Siewior <[email protected]>

Looks OK but there is another one of these in drivers/crypto.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Subject: Re: [RFC] [crypto] AES shorten the Kconfig entry

* Herbert Xu | 2008-04-05 21:07:27 [+0800]:

>On Fri, Mar 28, 2008 at 11:39:52PM +0100, Sebastian Siewior wrote:
>> Remove copied / duplicate entry from the assemble version and add a
>> small hint that the assembly version performs better and is not
>> a relict.
>>
>> Signed-off-by: Sebastian Siewior <[email protected]>
>
>Looks OK but there is another one of these in drivers/crypto.
Okey. So if you like that one I check the other file as well.

>Cheers,
Sebastian