2008-08-04 03:14:47

by Herbert Xu

[permalink] [raw]
Subject: crypto: hash - Fix digest size check for digest type


The new crypto testing stuff I've been working on has revealed
a harmless regression in crc32c when the old algorithm is used
through the new interface (which can't happen in practice).

commit e3698cd1602280dad00eb134a1803291c6b56407
Author: Herbert Xu <[email protected]>
Date: Sun Aug 3 21:19:43 2008 +0800

crypto: hash - Fix digest size check for digest type

The changeset ca786dc738f4f583b57b1bba7a335b5e8233f4b0

crypto: hash - Fixed digest size check

missed one spot for the digest type. This patch corrects that

Signed-off-by: Herbert Xu <[email protected]>

diff --git a/crypto/digest.c b/crypto/digest.c
index ac09194..5d3f130 100644
--- a/crypto/digest.c
+++ b/crypto/digest.c
@@ -225,7 +225,7 @@ int crypto_init_digest_ops_async(struct crypto_tfm *tfm)
struct ahash_tfm *crt = &tfm->crt_ahash;
struct digest_alg *dalg = &tfm->__crt_alg->cra_digest;

- if (dalg->dia_digestsize > crypto_tfm_alg_blocksize(tfm))
+ if (dalg->dia_digestsize > PAGE_SIZE / 8)
return -EINVAL;

crt->init = digest_async_init;

Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt