2008-11-09 16:54:20

by Julia Lawall

[permalink] [raw]
Subject: [PATCH 1/8] crypto/md4.c: use ARRAY_SIZE

From: Julia Lawall <[email protected]>

ARRAY_SIZE is more concise to use when the size of an array is divided by
the size of its type or the size of its first element.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@[email protected]
@@

#include <linux/kernel.h>

@depends on i using "paren.iso"@
type T;
T[] E;
@@

- (sizeof(E)/sizeof(T))
+ ARRAY_SIZE(E)
// </smpl>

Signed-off-by: Julia Lawall <[email protected]>

---
crypto/md4.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/md4.c b/crypto/md4.c
index 3c19aa0..a143c4a 100644
--- a/crypto/md4.c
+++ b/crypto/md4.c
@@ -148,7 +148,7 @@ static void md4_transform(u32 *hash, u32 const *in)

static inline void md4_transform_helper(struct md4_ctx *ctx)
{
- le32_to_cpu_array(ctx->block, sizeof(ctx->block) / sizeof(u32));
+ le32_to_cpu_array(ctx->block, ARRAY_SIZE(ctx->block));
md4_transform(ctx->hash, ctx->block);
}

@@ -214,7 +214,7 @@ static void md4_final(struct crypto_tfm *tfm, u8 *out)
le32_to_cpu_array(mctx->block, (sizeof(mctx->block) -
sizeof(u64)) / sizeof(u32));
md4_transform(mctx->hash, mctx->block);
- cpu_to_le32_array(mctx->hash, sizeof(mctx->hash) / sizeof(u32));
+ cpu_to_le32_array(mctx->hash, ARRAY_SIZE(mctx->hash));
memcpy(out, mctx->hash, sizeof(mctx->hash));
memset(mctx, 0, sizeof(*mctx));
}


2008-11-13 13:19:25

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH 1/8] crypto/md4.c: use ARRAY_SIZE

On Sun, Nov 09, 2008 at 05:54:15PM +0100, Julia Lawall wrote:
> From: Julia Lawall <[email protected]>
>
> ARRAY_SIZE is more concise to use when the size of an array is divided by
> the size of its type or the size of its first element.

Applied to cryptodev. Thanks!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt