2009-07-22 12:50:30

by Steffen Klassert

Subject: [PATCH] crypto: shash - Test for the algorithms import function before exporting it

crypto_init_shash_ops_async() tests for setkey and not for import
before exporting the algorithms import function to ahash.
This patch fixes this.

Signed-off-by: Steffen Klassert <[email protected]>
---
crypto/shash.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/crypto/shash.c b/crypto/shash.c
index 7713b52..d923c88 100644
--- a/crypto/shash.c
+++ b/crypto/shash.c
@@ -348,7 +348,7 @@ int crypto_init_shash_ops_async(struct crypto_tfm *tfm)
crt->setkey = shash_async_setkey;
if (alg->export)
crt->export = shash_async_export;
- if (alg->setkey)
+ if (alg->import)
crt->import = shash_async_import;

crt->reqsize = sizeof(struct shash_desc) + crypto_shash_descsize(shash);
--
1.5.4.2

2009-07-24 05:57:34

by Herbert Xu

Subject: Re: [PATCH] crypto: shash - Test for the algorithms import function before exporting it

On Wed, Jul 22, 2009 at 02:53:02PM +0200, Steffen Klassert wrote:
> crypto_init_shash_ops_async() tests for setkey and not for import
> before exporting the algorithms import function to ahash.
> This patch fixes this.
>
> Signed-off-by: Steffen Klassert <[email protected]>

Patch applied. Thanks!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt