2010-08-11 11:13:23

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH 2/4] /dev/crypto implementation

On Thu, Aug 05, 2010 at 10:17:55PM +0200, Miloslav Trma─Ź wrote:
>
> +static const struct algo_properties_st algo_properties[] = {
> + { .algo = NCR_ALG_NULL, .kstr = "ecb(cipher_null)",
> + .needs_iv = 0, .is_symmetric=1, .can_encrypt=1,
> + .key_type = NCR_KEY_TYPE_INVALID },

Hard-coding names like this is completely unacceptable. User-space
should be able to specify the algorithm as a string.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt