2010-10-24 13:05:56

by Nicolas Kaiser

Subject: [PATCH] drivers/crypto: dubious error check

Looks like a copy-and-paste problem to me.

Signed-off-by: Nicolas Kaiser <[email protected]>
---
drivers/crypto/n2_core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c
index 88ee015..7614126 100644
--- a/drivers/crypto/n2_core.c
+++ b/drivers/crypto/n2_core.c
@@ -1832,7 +1832,7 @@ static int __devinit get_irq_props(struct mdesc_handle *mdesc, u64 node,
return -ENODEV;

ino = mdesc_get_property(mdesc, node, "ino", &ino_len);
- if (!intr)
+ if (!ino)
return -ENODEV;

if (intr_len != ino_len)
--
1.7.2.2

2010-10-24 16:39:27

by David Miller

Subject: Re: [PATCH] drivers/crypto: dubious error check

From: Nicolas Kaiser <[email protected]>
Date: Sun, 24 Oct 2010 15:05:56 +0200

> Looks like a copy-and-paste problem to me.
>
> Signed-off-by: Nicolas Kaiser <[email protected]>

Acked-by: David S. Miller <[email protected]>

2010-10-25 23:26:08

by Herbert Xu

Subject: Re: [PATCH] drivers/crypto: dubious error check

On Sun, Oct 24, 2010 at 09:39:49AM -0700, David Miller wrote:
> From: Nicolas Kaiser <[email protected]>
> Date: Sun, 24 Oct 2010 15:05:56 +0200
>
> > Looks like a copy-and-paste problem to me.
> >
> > Signed-off-by: Nicolas Kaiser <[email protected]>
>
> Acked-by: David S. Miller <[email protected]>

Applied to crypto-2.6. Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt