2011-06-21 16:39:02

by Kim Phillips

[permalink] [raw]
Subject: Re: [PATCH] hwrng: ppc4xx - add support for ppc4xx TRNG

[adding linux-crypto]

On Tue, 21 Jun 2011 10:56:02 -0500
Matt Mackall <[email protected]> wrote:

> On Tue, 2011-06-21 at 08:19 -0400, Josh Boyer wrote:
> > +static struct hwrng ppc4xx_rng = {
> > + .name = MODULE_NAME,
> > + .data_present = ppc4xx_rng_data_present,
> > + .data_read = ppc4xx_rng_data_read,
> > +};

under what criteria should new hwrng drivers use the new hwrng API?

See commit bb347d9 "hwrng: virtio-rng - Convert to new API".

Kim


2011-06-21 19:00:00

by Matt Mackall

[permalink] [raw]
Subject: Re: [PATCH] hwrng: ppc4xx - add support for ppc4xx TRNG

On Tue, 2011-06-21 at 11:38 -0500, Kim Phillips wrote:
> [adding linux-crypto]
>
> On Tue, 21 Jun 2011 10:56:02 -0500
> Matt Mackall <[email protected]> wrote:
>
> > On Tue, 2011-06-21 at 08:19 -0400, Josh Boyer wrote:
> > > +static struct hwrng ppc4xx_rng = {
> > > + .name = MODULE_NAME,
> > > + .data_present = ppc4xx_rng_data_present,
> > > + .data_read = ppc4xx_rng_data_read,
> > > +};
>
> under what criteria should new hwrng drivers use the new hwrng API?

If the RNG is not fundamentally u32-based (like this one), it's strongly
encouraged. We'll eventually abandon the old interface, but I don't
think there's any hurry.

--
Mathematics is the supreme nostalgia of our time.