2011-10-10 09:32:18

by Jussi Kivilinna

Subject: [PATCH] crypto: blowfish-x86_64: fix ctr blocksize to 1

Signed-off-by: Jussi Kivilinna <[email protected]>
---
arch/x86/crypto/blowfish_glue.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/crypto/blowfish_glue.c b/arch/x86/crypto/blowfish_glue.c
index 40911ab..dd3964a 100644
--- a/arch/x86/crypto/blowfish_glue.c
+++ b/arch/x86/crypto/blowfish_glue.c
@@ -423,7 +423,7 @@ static struct crypto_alg blk_ctr_alg = {
.cra_driver_name = "ctr-blowfish-asm",
.cra_priority = 300,
.cra_flags = CRYPTO_ALG_TYPE_BLKCIPHER,
- .cra_blocksize = BF_BLOCK_SIZE,
+ .cra_blocksize = 1,
.cra_ctxsize = sizeof(struct bf_ctx),
.cra_alignmask = 0,
.cra_type = &crypto_blkcipher_type,

2011-10-21 12:17:53

by Herbert Xu

Subject: Re: [PATCH] crypto: blowfish-x86_64: fix ctr blocksize to 1

On Mon, Oct 10, 2011 at 12:32:15PM +0300, Jussi Kivilinna wrote:
> Signed-off-by: Jussi Kivilinna <[email protected]>

What is the rationale for this? Blowfish is not a stream cipher.

Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2011-10-21 12:19:10

by Herbert Xu

Subject: Re: [PATCH] crypto: blowfish-x86_64: fix ctr blocksize to 1

On Fri, Oct 21, 2011 at 02:17:49PM +0200, Herbert Xu wrote:
> On Mon, Oct 10, 2011 at 12:32:15PM +0300, Jussi Kivilinna wrote:
> > Signed-off-by: Jussi Kivilinna <[email protected]>
>
> What is the rationale for this? Blowfish is not a stream cipher.

Scratch that, I missed the bit about ctr.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2011-10-21 12:39:18

by Herbert Xu

Subject: Re: [PATCH] crypto: blowfish-x86_64: fix ctr blocksize to 1

On Mon, Oct 10, 2011 at 12:32:15PM +0300, Jussi Kivilinna wrote:
> Signed-off-by: Jussi Kivilinna <[email protected]>

Applied.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt