2012-05-12 09:30:32

by Alexander Clouter

[permalink] [raw]
Subject: [PATCH] crypto: mv_cesa requires on CRYPTO_HASH to build

Without CRYPTO_HASH being selected, mv_cesa has a lot of hooks
into undefined exports.
----
MODPOST 81 modules
Kernel: arch/arm/boot/Image is ready
AS arch/arm/boot/compressed/head.o
GZIP arch/arm/boot/compressed/piggy.gzip
CC arch/arm/boot/compressed/misc.o
CC arch/arm/boot/compressed/decompress.o
ERROR: "crypto_ahash_type" [drivers/crypto/mv_cesa.ko] undefined!
ERROR: "crypto_shash_final" [drivers/crypto/mv_cesa.ko] undefined!
ERROR: "crypto_register_ahash" [drivers/crypto/mv_cesa.ko] undefined!
ERROR: "crypto_unregister_ahash" [drivers/crypto/mv_cesa.ko] undefined!
ERROR: "crypto_shash_update" [drivers/crypto/mv_cesa.ko] undefined!
ERROR: "crypto_shash_digest" [drivers/crypto/mv_cesa.ko] undefined!
ERROR: "crypto_shash_setkey" [drivers/crypto/mv_cesa.ko] undefined!
ERROR: "crypto_alloc_shash" [drivers/crypto/mv_cesa.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
make: *** Waiting for unfinished jobs....
----

Signed-off-by: Alexander Clouter <[email protected]>
---
drivers/crypto/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index e707979..07dbc77 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -173,6 +173,7 @@ config CRYPTO_DEV_MV_CESA
select CRYPTO_ALGAPI
select CRYPTO_AES
select CRYPTO_BLKCIPHER2
+ select CRYPTO_HASH
help
This driver allows you to utilize the Cryptographic Engines and
Security Accelerator (CESA) which can be found on the Marvell Orion
--
1.7.10


2012-05-12 14:02:25

by Jason Cooper

[permalink] [raw]
Subject: Re: [PATCH] crypto: mv_cesa requires on CRYPTO_HASH to build

Herbert,

I'm putting together a pull request of fixes for arm:kirkwood
3.4/stable, shall I add this to my tree, or would you like to take it in
through yours?

On Sat, May 12, 2012 at 09:45:08AM +0100, Alexander Clouter wrote:
> Without CRYPTO_HASH being selected, mv_cesa has a lot of hooks
> into undefined exports.
> ----

Alexander,

minor nit: Do you intend the below to be a part of the commit message?
You may want to choose a different separator...

> MODPOST 81 modules
> Kernel: arch/arm/boot/Image is ready
> AS arch/arm/boot/compressed/head.o
> GZIP arch/arm/boot/compressed/piggy.gzip
> CC arch/arm/boot/compressed/misc.o
> CC arch/arm/boot/compressed/decompress.o
> ERROR: "crypto_ahash_type" [drivers/crypto/mv_cesa.ko] undefined!
> ERROR: "crypto_shash_final" [drivers/crypto/mv_cesa.ko] undefined!
> ERROR: "crypto_register_ahash" [drivers/crypto/mv_cesa.ko] undefined!
> ERROR: "crypto_unregister_ahash" [drivers/crypto/mv_cesa.ko] undefined!
> ERROR: "crypto_shash_update" [drivers/crypto/mv_cesa.ko] undefined!
> ERROR: "crypto_shash_digest" [drivers/crypto/mv_cesa.ko] undefined!
> ERROR: "crypto_shash_setkey" [drivers/crypto/mv_cesa.ko] undefined!
> ERROR: "crypto_alloc_shash" [drivers/crypto/mv_cesa.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> make: *** Waiting for unfinished jobs....
> ----
>
> Signed-off-by: Alexander Clouter <[email protected]>

Acked-By: Jason Cooper <[email protected]>

thx,

Jason.

> ---
> drivers/crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index e707979..07dbc77 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -173,6 +173,7 @@ config CRYPTO_DEV_MV_CESA
> select CRYPTO_ALGAPI
> select CRYPTO_AES
> select CRYPTO_BLKCIPHER2
> + select CRYPTO_HASH
> help
> This driver allows you to utilize the Cryptographic Engines and
> Security Accelerator (CESA) which can be found on the Marvell Orion
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2012-05-12 21:04:18

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] crypto: mv_cesa requires on CRYPTO_HASH to build

On Sat, May 12, 2012 at 10:02:19AM -0400, Jason Cooper wrote:
> Herbert,
>
> I'm putting together a pull request of fixes for arm:kirkwood
> 3.4/stable, shall I add this to my tree, or would you like to take it in
> through yours?

Feel free to push it through you tree.

Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt