On 07/02/2012 12:23 AM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20120629:
>
on i386:
ERROR: "__divdi3" [drivers/crypto/hifn_795x.ko] undefined!
--
~Randy
On Mon, Jul 2, 2012 at 6:27 PM, Randy Dunlap <[email protected]> wrote:
> On 07/02/2012 12:23 AM, Stephen Rothwell wrote:
>> Changes since 20120629:
>
> on i386:
>
> ERROR: "__divdi3" [drivers/crypto/hifn_795x.ko] undefined!
Also on ppc6xx_defconfig
http://kisskb.ellerman.id.au/kisskb/buildresult/6650268/
It doesn't happen in mainline, but there were no changes in
drivers/crypto/hifn_795x.c.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoting Randy Dunlap <[email protected]>:
> On 07/02/2012 12:23 AM, Stephen Rothwell wrote:
>
>> Hi all,
>>
>> Changes since 20120629:
>>
>
>
> on i386:
>
>
> ERROR: "__divdi3" [drivers/crypto/hifn_795x.ko] undefined!
>
This is caused by commit feb7b7ab928afa97a79a9c424e4e0691f49d63be.
hifn_795x has "DIV_ROUND_UP(NSEC_PER_SEC, dev->pk_clk_freq)", which
should be changed to DIV_ROUND_UP_ULL now that NSEC_PER_SEC is 64bit
on 32bit archs. Patch to fix hifn_795x is attached (only compile
tested).
-Jussi
On 07/09/2012 10:54 AM, Jussi Kivilinna wrote:
> Quoting Randy Dunlap <[email protected]>:
>
>> On 07/02/2012 12:23 AM, Stephen Rothwell wrote:
>>
>>> Hi all,
>>>
>>> Changes since 20120629:
>>>
>>
>>
>> on i386:
>>
>>
>> ERROR: "__divdi3" [drivers/crypto/hifn_795x.ko] undefined!
>>
>
> This is caused by commit feb7b7ab928afa97a79a9c424e4e0691f49d63be. hifn_795x has "DIV_ROUND_UP(NSEC_PER_SEC, dev->pk_clk_freq)", which should be changed to DIV_ROUND_UP_ULL now that NSEC_PER_SEC is 64bit on 32bit archs. Patch to fix hifn_795x is attached (only compile tested).
Acked-by: Randy Dunlap <[email protected]>
Thanks.
--
~Randy
On Mon, Jul 09, 2012 at 09:40:22PM +0000, Randy Dunlap wrote:
> On 07/09/2012 10:54 AM, Jussi Kivilinna wrote:
>
> > Quoting Randy Dunlap <[email protected]>:
> >
> >> On 07/02/2012 12:23 AM, Stephen Rothwell wrote:
> >>
> >>> Hi all,
> >>>
> >>> Changes since 20120629:
> >>>
> >>
> >>
> >> on i386:
> >>
> >>
> >> ERROR: "__divdi3" [drivers/crypto/hifn_795x.ko] undefined!
> >>
> >
> > This is caused by commit feb7b7ab928afa97a79a9c424e4e0691f49d63be. hifn_795x has "DIV_ROUND_UP(NSEC_PER_SEC, dev->pk_clk_freq)", which should be changed to DIV_ROUND_UP_ULL now that NSEC_PER_SEC is 64bit on 32bit archs. Patch to fix hifn_795x is attached (only compile tested).
>
>
>
> Acked-by: Randy Dunlap <[email protected]>
Patch applied. Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt