2012-08-27 10:17:52

by Sachin Kamat

Subject: [PATCH] crypto: geode-aes: Use module_pci_driver

module_pci_driver makes the code simpler by eliminating
module_init and module_exit calls.

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/crypto/geode-aes.c | 15 +--------------
1 files changed, 1 insertions(+), 14 deletions(-)

diff --git a/drivers/crypto/geode-aes.c b/drivers/crypto/geode-aes.c
index 933fb4b4..51f196d 100644
--- a/drivers/crypto/geode-aes.c
+++ b/drivers/crypto/geode-aes.c
@@ -585,21 +585,8 @@ static struct pci_driver geode_aes_driver = {
.remove = __devexit_p(geode_aes_remove)
};

-static int __init
-geode_aes_init(void)
-{
- return pci_register_driver(&geode_aes_driver);
-}
-
-static void __exit
-geode_aes_exit(void)
-{
- pci_unregister_driver(&geode_aes_driver);
-}
+module_pci_driver(geode_aes_driver);

MODULE_AUTHOR("Advanced Micro Devices, Inc.");
MODULE_DESCRIPTION("Geode LX Hardware AES driver");
MODULE_LICENSE("GPL");
-
-module_init(geode_aes_init);
-module_exit(geode_aes_exit);
--
1.7.4.1

2012-09-06 04:11:07

by Sachin Kamat

Subject: Re: [PATCH] crypto: geode-aes: Use module_pci_driver

Hi,

Any comments on this patch?

On 27 August 2012 15:45, Sachin Kamat <[email protected]> wrote:
> module_pci_driver makes the code simpler by eliminating
> module_init and module_exit calls.
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> drivers/crypto/geode-aes.c | 15 +--------------
> 1 files changed, 1 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/crypto/geode-aes.c b/drivers/crypto/geode-aes.c
> index 933fb4b4..51f196d 100644
> --- a/drivers/crypto/geode-aes.c
> +++ b/drivers/crypto/geode-aes.c
> @@ -585,21 +585,8 @@ static struct pci_driver geode_aes_driver = {
> .remove = __devexit_p(geode_aes_remove)
> };
>
> -static int __init
> -geode_aes_init(void)
> -{
> - return pci_register_driver(&geode_aes_driver);
> -}
> -
> -static void __exit
> -geode_aes_exit(void)
> -{
> - pci_unregister_driver(&geode_aes_driver);
> -}
> +module_pci_driver(geode_aes_driver);
>
> MODULE_AUTHOR("Advanced Micro Devices, Inc.");
> MODULE_DESCRIPTION("Geode LX Hardware AES driver");
> MODULE_LICENSE("GPL");
> -
> -module_init(geode_aes_init);
> -module_exit(geode_aes_exit);
> --
> 1.7.4.1
>



--
With warm regards,
Sachin

2012-09-06 20:21:32

by Herbert Xu

Subject: Re: [PATCH] crypto: geode-aes: Use module_pci_driver

On Mon, Aug 27, 2012 at 03:45:31PM +0530, Sachin Kamat wrote:
> module_pci_driver makes the code simpler by eliminating
> module_init and module_exit calls.
>
> Signed-off-by: Sachin Kamat <[email protected]>

Patch applied.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt