2013-01-21 13:02:51

by Julia Lawall

[permalink] [raw]
Subject: [PATCH 7/15] drivers/crypto/atmel-aes.c: adjust duplicate test

From: Julia Lawall <[email protected]>

Delete successive tests to the same location. The code tested the result
of a previous allocation, that itself was already tested. It is changed to
test the result of the most recent allocation.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@s [email protected]
local idexpression y;
expression x,e;
@@

*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
{ ... when forall
return ...; }
... when != \(y = e\|y += e\|y -= e\|y |= e\|y &= e\|y++\|y--\|&y\)
when != \(XT_GETPAGE(...,y)\|WMI_CMD_BUF(...)\)
*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
{ ... when forall
return ...; }
// </smpl>

Signed-off-by: Julia Lawall <[email protected]>

---
drivers/crypto/atmel-aes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c
index c9d9d5c..6f22ba5 100644
--- a/drivers/crypto/atmel-aes.c
+++ b/drivers/crypto/atmel-aes.c
@@ -332,7 +332,7 @@ static int atmel_aes_crypt_cpu_start(struct atmel_aes_dev *dd)
return -EINVAL;

dd->nb_out_sg = atmel_aes_sg_length(dd->req, dd->out_sg);
- if (!dd->nb_in_sg)
+ if (!dd->nb_out_sg)
return -EINVAL;

dd->bufcnt = sg_copy_to_buffer(dd->in_sg, dd->nb_in_sg,


2013-01-21 18:19:14

by David Miller

[permalink] [raw]
Subject: Re: [PATCH 7/15] drivers/crypto/atmel-aes.c: adjust duplicate test

From: Julia Lawall <[email protected]>
Date: Mon, 21 Jan 2013 14:02:51 +0100

> From: Julia Lawall <[email protected]>
>
> Delete successive tests to the same location. The code tested the result
> of a previous allocation, that itself was already tested. It is changed to
> test the result of the most recent allocation.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Julia Lawall <[email protected]>

Acked-by: David S. Miller <[email protected]>

2013-02-04 13:21:28

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH 7/15] drivers/crypto/atmel-aes.c: adjust duplicate test

On Mon, Jan 21, 2013 at 01:19:12PM -0500, David Miller wrote:
> From: Julia Lawall <[email protected]>
> Date: Mon, 21 Jan 2013 14:02:51 +0100
>
> > From: Julia Lawall <[email protected]>
> >
> > Delete successive tests to the same location. The code tested the result
> > of a previous allocation, that itself was already tested. It is changed to
> > test the result of the most recent allocation.
> >
> > A simplified version of the semantic match that finds this problem is as
> > follows: (http://coccinelle.lip6.fr/)
> ...
> > Signed-off-by: Julia Lawall <[email protected]>
>
> Acked-by: David S. Miller <[email protected]>

Patch applied. Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt