2013-01-23 05:37:32

by Vakul Garg

[permalink] [raw]
Subject: [PATCH] crypto: caam - Added property fsl,sec-era in SEC4.0 device tree binding.

This new property defines the era of the particular SEC version.
The compatible property in device tree "crypto" node has been updated
not to contain SEC era numbers.

Signed-off-by: Vakul Garg <[email protected]>
---
.../devicetree/bindings/crypto/fsl-sec4.txt | 12 +++++++++---
1 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
index fc9ce6f..dc40055 100644
--- a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
+++ b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
@@ -54,8 +54,13 @@ PROPERTIES
- compatible
Usage: required
Value type: <string>
- Definition: Must include "fsl,sec-v4.0". Also includes SEC
- ERA versions (optional) with which the device is compatible.
+ Definition: Must include "fsl,sec-v4.0"
+
+ - fsl,sec-era
+ Usage: required
+ Value type: <u32>
+ Definition: A standard property. Define the 'ERA' of the SEC
+ device.

- #address-cells
Usage: required
@@ -107,7 +112,8 @@ PROPERTIES

EXAMPLE
[email protected] {
- compatible = "fsl,sec-v4.0", "fsl,sec-era-v2.0";
+ compatible = "fsl,sec-v4.0";
+ fsl,sec-era = <0x2>;
#address-cells = <1>;
#size-cells = <1>;
reg = <0x300000 0x10000>;
--
1.7.7.6


2013-01-23 22:37:35

by Kim Phillips

[permalink] [raw]
Subject: Re: [PATCH] crypto: caam - Added property fsl,sec-era in SEC4.0 device tree binding.

cc'ing devicetree-discuss. Start using scripts/get_maintainers.pl.

On Wed, 23 Jan 2013 11:04:55 +0530
Vakul Garg <[email protected]> wrote:

> +++ b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
> @@ -54,8 +54,13 @@ PROPERTIES
> - compatible
> Usage: required
> Value type: <string>
> - Definition: Must include "fsl,sec-v4.0". Also includes SEC
> - ERA versions (optional) with which the device is compatible.
> + Definition: Must include "fsl,sec-v4.0"
> +
> + - fsl,sec-era
> + Usage: required

what's the rationale for going from optional to required?

> EXAMPLE
> [email protected] {
> - compatible = "fsl,sec-v4.0", "fsl,sec-era-v2.0";
> + compatible = "fsl,sec-v4.0";
> + fsl,sec-era = <0x2>;

use decimal notation

Kim