2013-02-24 13:09:21

by Mathias Krause

Subject: [PATCH] crypto: user - constify netlink dispatch table

There is no need to modify the netlink dispatch table at runtime and
making it const even makes the resulting object file slightly smaller.

Cc: Steffen Klassert <[email protected]>
Signed-off-by: Mathias Krause <[email protected]>
---
crypto/crypto_user.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/crypto_user.c b/crypto/crypto_user.c
index 35d700a..77f6c4e 100644
--- a/crypto/crypto_user.c
+++ b/crypto/crypto_user.c
@@ -426,7 +426,7 @@ static const struct nla_policy crypto_policy[CRYPTOCFGA_MAX+1] = {

#undef MSGSIZE

-static struct crypto_link {
+static const struct crypto_link {
int (*doit)(struct sk_buff *, struct nlmsghdr *, struct nlattr **);
int (*dump)(struct sk_buff *, struct netlink_callback *);
int (*done)(struct netlink_callback *);
@@ -442,7 +442,7 @@ static struct crypto_link {
static int crypto_user_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
{
struct nlattr *attrs[CRYPTOCFGA_MAX+1];
- struct crypto_link *link;
+ const struct crypto_link *link;
int type, err;

type = nlh->nlmsg_type;
--
1.7.10.4

2013-03-10 10:15:04

by Herbert Xu

Subject: Re: [PATCH] crypto: user - constify netlink dispatch table

On Sun, Feb 24, 2013 at 02:09:12PM +0100, Mathias Krause wrote:
> There is no need to modify the netlink dispatch table at runtime and
> making it const even makes the resulting object file slightly smaller.
>
> Cc: Steffen Klassert <[email protected]>
> Signed-off-by: Mathias Krause <[email protected]>

Patch applied. Thanks Mathias!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt