2013-03-11 10:48:27

by Mihnea Dobrescu-Balaur

Subject: [PATCH] crypto: replace kmalloc and then memcpy with kmemdup

Signed-off-by: Mihnea Dobrescu-Balaur <[email protected]>
---
drivers/crypto/ux500/hash/hash_core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/crypto/ux500/hash/hash_core.c b/drivers/crypto/ux500/hash/hash_core.c
index 632c333..8d16d3a 100644
--- a/drivers/crypto/ux500/hash/hash_core.c
+++ b/drivers/crypto/ux500/hash/hash_core.c
@@ -1368,14 +1368,12 @@ static int hash_setkey(struct crypto_ahash *tfm,
/**
* Freed in final.
*/
- ctx->key = kmalloc(keylen, GFP_KERNEL);
+ ctx->key = kmemdup(key, keylen, GFP_KERNEL);
if (!ctx->key) {
pr_err(DEV_DBG_NAME " [%s] Failed to allocate ctx->key "
"for %d\n", __func__, alg);
return -ENOMEM;
}
-
- memcpy(ctx->key, key, keylen);
ctx->keylen = keylen;

return ret;
--
1.7.10.4

2013-03-21 09:54:35

by Herbert Xu

Subject: Re: [PATCH] crypto: replace kmalloc and then memcpy with kmemdup

On Mon, Mar 11, 2013 at 12:48:10PM +0200, Mihnea Dobrescu-Balaur wrote:
> Signed-off-by: Mihnea Dobrescu-Balaur <[email protected]>

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2013-03-21 18:18:45

by Linus Walleij

Subject: Re: [PATCH] crypto: replace kmalloc and then memcpy with kmemdup

On Thu, Mar 21, 2013 at 10:54 AM, Herbert Xu
<[email protected]> wrote:
> On Mon, Mar 11, 2013 at 12:48:10PM +0200, Mihnea Dobrescu-Balaur wrote:
>> Signed-off-by: Mihnea Dobrescu-Balaur <[email protected]>
>
> Patch applied. Thanks.

Acked-by: Linus Walleij <[email protected]> FWIW, I tried to get the
people involved with the code to ACK but somehow they must've missed it.

Thanks,
Linus Walleij