2016-01-19 17:34:09

by Cabiddu, Giovanni

Subject: [PATCH] Reduced reqsize in qat_algs

From: Cabiddu, Giovanni <[email protected]>

req_alloc functions already take into account the request data structure
when allocating memory.

Signed-off-by: Giovanni Cabiddu <[email protected]>
Signed-off-by: Tadeusz Struk <[email protected]>
---
drivers/crypto/qat/qat_common/qat_algs.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/qat/qat_common/qat_algs.c b/drivers/crypto/qat/qat_common/qat_algs.c
index 59e4c3af..1e8852a8 100644
--- a/drivers/crypto/qat/qat_common/qat_algs.c
+++ b/drivers/crypto/qat/qat_common/qat_algs.c
@@ -1064,8 +1064,7 @@ static int qat_alg_aead_init(struct crypto_aead *tfm,
if (IS_ERR(ctx->hash_tfm))
return PTR_ERR(ctx->hash_tfm);
ctx->qat_hash_alg = hash;
- crypto_aead_set_reqsize(tfm, sizeof(struct aead_request) +
- sizeof(struct qat_crypto_request));
+ crypto_aead_set_reqsize(tfm, sizeof(struct qat_crypto_request));
return 0;
}

@@ -1114,8 +1113,7 @@ static int qat_alg_ablkcipher_init(struct crypto_tfm *tfm)
struct qat_alg_ablkcipher_ctx *ctx = crypto_tfm_ctx(tfm);

spin_lock_init(&ctx->lock);
- tfm->crt_ablkcipher.reqsize = sizeof(struct ablkcipher_request) +
- sizeof(struct qat_crypto_request);
+ tfm->crt_ablkcipher.reqsize = sizeof(struct qat_crypto_request);
ctx->tfm = tfm;
return 0;
}
--
1.7.4.1

2016-01-25 14:49:17

by Herbert Xu

Subject: Re: [PATCH] Reduced reqsize in qat_algs

On Tue, Jan 19, 2016 at 05:34:04PM +0000, Giovanni Cabiddu wrote:
> From: Cabiddu, Giovanni <[email protected]>
>
> req_alloc functions already take into account the request data structure
> when allocating memory.
>
> Signed-off-by: Giovanni Cabiddu <[email protected]>
> Signed-off-by: Tadeusz Struk <[email protected]>

Applied.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt