On Mon, 26 Apr 2021 at 10:58, Will Deacon <[email protected]> wrote:
>
> [+Ard]
>
> On Mon, Apr 26, 2021 at 02:57:33AM +0900, Masahiro Yamada wrote:
> > Generate *.S by Perl like arch/{mips,x86}/crypto/Makefile.
> >
> > Signed-off-by: Masahiro Yamada <[email protected]>
> > ---
> >
> > arch/arm64/crypto/Makefile | 9 +-
> > arch/arm64/crypto/poly1305-core.S_shipped | 835 ---------
> > arch/arm64/crypto/sha256-core.S_shipped | 2069 ---------------------
> > arch/arm64/crypto/sha512-core.S_shipped | 1093 -----------
> > 4 files changed, 3 insertions(+), 4003 deletions(-)
> > delete mode 100644 arch/arm64/crypto/poly1305-core.S_shipped
> > delete mode 100644 arch/arm64/crypto/sha256-core.S_shipped
> > delete mode 100644 arch/arm64/crypto/sha512-core.S_shipped
>
> What's the advantage of removing the _shipped files? We included them
> originally so that we didn't require perl for the kernel build -- is that no
> longer an issue?
>
> I guess I'm just missing the justification for the change.
Removing 4000 lines of code is an improvement in itself, I suppose,
but I have no preference either way,