2021-07-18 22:14:13

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the crypto tree

Hi all,

In commit

5261cdf457ce ("crypto: drbg - select SHA512")

Fixes tag

Fixes: 9b7b94683a9b "crypto: DRBG - switch to HMAC SHA512 DRBG as default

has these problem(s):

- Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-07-19 05:44:36

by Stephan Mueller

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the crypto tree

Am Montag, dem 19.07.2021 um 08:13 +1000 schrieb Stephen Rothwell:
> Hi all,

Hi Stephen, Herbert
>
> In commit
>
>   5261cdf457ce ("crypto: drbg - select SHA512")
>
> Fixes tag
>
>   Fixes: 9b7b94683a9b "crypto: DRBG - switch to HMAC SHA512 DRBG as default
>
> has these problem(s):
>
>   - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line.
>

Thank you for the report.

Herbert, how do we go about this fix? I can surely prepare another patch. But
considering that the old patch is already in the git tree, are you considering
to revert it?

Thanks
Stephan

2021-07-19 05:47:01

by Herbert Xu

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the crypto tree

On Mon, Jul 19, 2021 at 07:43:29AM +0200, Stephan Mueller wrote:
>
> Herbert, how do we go about this fix? I can surely prepare another patch. But
> considering that the old patch is already in the git tree, are you considering
> to revert it?

I think we should keep this in mind for future submissions.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt