2022-01-13 01:14:10

by Colin Ian King

[permalink] [raw]
Subject: [PATCH] crypto: asymmetric_keys: remove redundant pointer secs

The pointer secs is assigned a value but it is never read. The
pointer is redundant and can be removed. Cleans up clang scan
warning:

crypto/asymmetric_keys/verify_pefile.c:113:14: warning: Although
the value stored to 'secs' is used in the enclosing expression,
the value is never actually read from 'secs' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
crypto/asymmetric_keys/verify_pefile.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/asymmetric_keys/verify_pefile.c b/crypto/asymmetric_keys/verify_pefile.c
index 7553ab18db89..a660e4d68d50 100644
--- a/crypto/asymmetric_keys/verify_pefile.c
+++ b/crypto/asymmetric_keys/verify_pefile.c
@@ -28,7 +28,7 @@ static int pefile_parse_binary(const void *pebuf, unsigned int pelen,
const struct pe32plus_opt_hdr *pe64;
const struct data_directory *ddir;
const struct data_dirent *dde;
- const struct section_header *secs, *sec;
+ const struct section_header *sec;
size_t cursor, datalen = pelen;

kenter("");
@@ -110,7 +110,7 @@ static int pefile_parse_binary(const void *pebuf, unsigned int pelen,
ctx->n_sections = pe->sections;
if (ctx->n_sections > (ctx->header_size - cursor) / sizeof(*sec))
return -ELIBBAD;
- ctx->secs = secs = pebuf + cursor;
+ ctx->secs = pebuf + cursor;

return 0;
}
--
2.33.1