2021-12-18 13:26:48

by kernel test robot

[permalink] [raw]
Subject: [PATCH] crypto: fix semicolon.cocci warnings

From: kernel test robot <[email protected]>

drivers/crypto/ccp/sev-dev.c:263:2-3: Unneeded semicolon


Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: 3d725965f836 ("crypto: ccp - Add SEV_INIT_EX support")
CC: David Rientjes <[email protected]>
Reported-by: kernel test robot <[email protected]>
Signed-off-by: kernel test robot <[email protected]>
---

tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head: 696645d25bafd6ba3562611c29bc8ecd47066dfe
commit: 3d725965f836a7acbd1674e33644bec18373de53 [83/95] crypto: ccp - Add SEV_INIT_EX support
:::::: branch date: 31 hours ago
:::::: commit date: 31 hours ago

sev-dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/crypto/ccp/sev-dev.c
+++ b/drivers/crypto/ccp/sev-dev.c
@@ -260,7 +260,7 @@ static void sev_write_init_ex_file_if_re
break;
default:
return;
- };
+ }

sev_write_init_ex_file();
}


2021-12-24 03:28:43

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] crypto: fix semicolon.cocci warnings

On Sat, Dec 18, 2021 at 09:25:42PM +0800, kernel test robot wrote:
> From: kernel test robot <[email protected]>
>
> drivers/crypto/ccp/sev-dev.c:263:2-3: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: 3d725965f836 ("crypto: ccp - Add SEV_INIT_EX support")
> CC: David Rientjes <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: kernel test robot <[email protected]>
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head: 696645d25bafd6ba3562611c29bc8ecd47066dfe
> commit: 3d725965f836a7acbd1674e33644bec18373de53 [83/95] crypto: ccp - Add SEV_INIT_EX support
> :::::: branch date: 31 hours ago
> :::::: commit date: 31 hours ago
>
> sev-dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

I don't know what happened but your patch isn't in patchwork.
Could you please try resending?

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2022-01-04 21:14:41

by Peter Gonda

[permalink] [raw]
Subject: Re: [PATCH] crypto: fix semicolon.cocci warnings

On Thu, Dec 23, 2021 at 8:28 PM Herbert Xu <[email protected]> wrote:
>
> On Sat, Dec 18, 2021 at 09:25:42PM +0800, kernel test robot wrote:
> > From: kernel test robot <[email protected]>
> >
> > drivers/crypto/ccp/sev-dev.c:263:2-3: Unneeded semicolon
> >
> >
> > Remove unneeded semicolon.
> >
> > Generated by: scripts/coccinelle/misc/semicolon.cocci
> >
> > Fixes: 3d725965f836 ("crypto: ccp - Add SEV_INIT_EX support")
> > CC: David Rientjes <[email protected]>
> > Reported-by: kernel test robot <[email protected]>
> > Signed-off-by: kernel test robot <[email protected]>
> > ---
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> > head: 696645d25bafd6ba3562611c29bc8ecd47066dfe
> > commit: 3d725965f836a7acbd1674e33644bec18373de53 [83/95] crypto: ccp - Add SEV_INIT_EX support
> > :::::: branch date: 31 hours ago
> > :::::: commit date: 31 hours ago
> >
> > sev-dev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I don't know what happened but your patch isn't in patchwork.
> Could you please try resending?

Herbert I see the patches I sent here:
https://patchwork.kernel.org/project/linux-crypto/list/?series=591933&state=%2A&archive=both.

Are you asking for this bot to resend? Or should I send a fix up patch
if that's easier.

>
> Thanks,
> --
> Email: Herbert Xu <[email protected]>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2022-01-05 00:30:07

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] crypto: fix semicolon.cocci warnings

On Tue, Jan 04, 2022 at 02:14:16PM -0700, Peter Gonda wrote:
>
> Herbert I see the patches I sent here:
> https://patchwork.kernel.org/project/linux-crypto/list/?series=591933&state=%2A&archive=both.

I meant the bot's patch.

> Are you asking for this bot to resend? Or should I send a fix up patch
> if that's easier.

If you could resend the bot's fix up patch that would be great.

Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2022-01-05 15:20:33

by Peter Gonda

[permalink] [raw]
Subject: Re: [PATCH] crypto: fix semicolon.cocci warnings

On Tue, Jan 4, 2022 at 5:30 PM Herbert Xu <[email protected]> wrote:
>
> On Tue, Jan 04, 2022 at 02:14:16PM -0700, Peter Gonda wrote:
> >
> > Herbert I see the patches I sent here:
> > https://patchwork.kernel.org/project/linux-crypto/list/?series=591933&state=%2A&archive=both.
>
> I meant the bot's patch.
>
> > Are you asking for this bot to resend? Or should I send a fix up patch
> > if that's easier.
>
> If you could resend the bot's fix up patch that would be great.

My mistake, I should have checked first. Someone has already done
this: https://patchwork.kernel.org/project/linux-crypto/patch/[email protected]/
.
>
> Thanks!
> --
> Email: Herbert Xu <[email protected]>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt