2022-01-16 02:08:31

by Corentin LABBE

Subject: [PATCH] crypto: sun8i-ss: really disable hash on A80

When adding hashes support to sun8i-ss, I have added them only on A83T.
But I forgot that 0 is a valid algorithm ID, so hashes are enabled on A80 but
with an incorrect ID.
Anyway, even with correct IDs, hashes do not work on A80 and I cannot
find why.
So let's disable all of them on A80.

Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithms")
Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
index 80e89066dbd1..319fe3279a71 100644
--- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
+++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
@@ -30,6 +30,8 @@
static const struct ss_variant ss_a80_variant = {
.alg_cipher = { SS_ALG_AES, SS_ALG_DES, SS_ALG_3DES,
},
+ .alg_hash = { SS_ID_NOTSUPP, SS_ID_NOTSUPP, SS_ID_NOTSUPP, SS_ID_NOTSUPP,
+ },
.op_mode = { SS_OP_ECB, SS_OP_CBC,
},
.ss_clks = {
--
2.34.1

2022-01-29 22:03:44

by Herbert Xu

Subject: Re: [PATCH] crypto: sun8i-ss: really disable hash on A80

On Sat, Jan 15, 2022 at 10:07:14AM +0000, Corentin Labbe wrote:
> When adding hashes support to sun8i-ss, I have added them only on A83T.
> But I forgot that 0 is a valid algorithm ID, so hashes are enabled on A80 but
> with an incorrect ID.
> Anyway, even with correct IDs, hashes do not work on A80 and I cannot
> find why.
> So let's disable all of them on A80.
>
> Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithms")
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 2 ++
> 1 file changed, 2 insertions(+)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt