2022-04-22 20:10:46

by Pali Rohár

[permalink] [raw]
Subject: [PATCH] crypto: atmel-sha204a: Add support for ATSHA204 cryptochip

ATSHA204 is predecessor of ATSHA204A which supports less features and some
of them are slightly different.

Introduce a new compatible string for ATSHA204 cryptochip "atmel,atsha204".

Current version of Linux kernel driver atmel-sha204a.c implements only hw
random number generator which is same in both ATSHA204 and ATSHA204A
cryptochips. So driver already supports also ATSHA204 hw generator, so just
simply extends list of compatible strings.

Signed-off-by: Pali Rohár <[email protected]>
---
Documentation/devicetree/bindings/trivial-devices.yaml | 4 +++-
drivers/crypto/atmel-sha204a.c | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 091792ba993e..bbff73e1b03a 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -47,7 +47,9 @@ properties:
- at,24c08
# i2c trusted platform module (TPM)
- atmel,at97sc3204t
- # i2c h/w symmetric crypto module
+ # ATSHA204 - i2c h/w symmetric crypto module
+ - atmel,atsha204
+ # ATSHA204A - i2c h/w symmetric crypto module
- atmel,atsha204a
# i2c h/w elliptic curve crypto module
- atmel,atecc508a
diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
index c96c14e7dab1..3a03f4aaf100 100644
--- a/drivers/crypto/atmel-sha204a.c
+++ b/drivers/crypto/atmel-sha204a.c
@@ -132,12 +132,14 @@ static int atmel_sha204a_remove(struct i2c_client *client)
}

static const struct of_device_id atmel_sha204a_dt_ids[] = {
+ { .compatible = "atmel,atsha204", },
{ .compatible = "atmel,atsha204a", },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, atmel_sha204a_dt_ids);

static const struct i2c_device_id atmel_sha204a_id[] = {
+ { "atsha204", 0 },
{ "atsha204a", 0 },
{ /* sentinel */ }
};
--
2.20.1


2022-05-02 22:08:55

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] crypto: atmel-sha204a: Add support for ATSHA204 cryptochip

On Thu, 21 Apr 2022 15:44:57 +0200, Pali Roh?r wrote:
> ATSHA204 is predecessor of ATSHA204A which supports less features and some
> of them are slightly different.
>
> Introduce a new compatible string for ATSHA204 cryptochip "atmel,atsha204".
>
> Current version of Linux kernel driver atmel-sha204a.c implements only hw
> random number generator which is same in both ATSHA204 and ATSHA204A
> cryptochips. So driver already supports also ATSHA204 hw generator, so just
> simply extends list of compatible strings.
>
> Signed-off-by: Pali Roh?r <[email protected]>
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 4 +++-
> drivers/crypto/atmel-sha204a.c | 2 ++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>

Acked-by: Rob Herring <[email protected]>