2022-05-01 21:47:43

by Masahiro Yamada

Subject: [PATCH] crypto: vmx - Align the short log with Makefile cleanups

I notieced the log is not properly aligned:

PERL drivers/crypto/vmx/aesp8-ppc.S
CC [M] fs/xfs/xfs_reflink.o
PERL drivers/crypto/vmx/ghashp8-ppc.S
CC [M] drivers/crypto/vmx/aes.o

Add some spaces after 'PERL'.

While I was here, I cleaned up the Makefile:

- Merge the two similar rules

- Remove redundant 'clean-files' (Having 'targets' is enough)

- Move the flavour into the build command

This still avoids the build failures fixed by commit 4ee812f6143d
("crypto: vmx - Avoid weird build failures").

Signed-off-by: Masahiro Yamada <[email protected]>
---

drivers/crypto/vmx/Makefile | 17 +++--------------
1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/drivers/crypto/vmx/Makefile b/drivers/crypto/vmx/Makefile
index 709670d2b553..df93ba63b1cd 100644
--- a/drivers/crypto/vmx/Makefile
+++ b/drivers/crypto/vmx/Makefile
@@ -2,21 +2,10 @@
obj-$(CONFIG_CRYPTO_DEV_VMX_ENCRYPT) += vmx-crypto.o
vmx-crypto-objs := vmx.o aesp8-ppc.o ghashp8-ppc.o aes.o aes_cbc.o aes_ctr.o aes_xts.o ghash.o

-ifeq ($(CONFIG_CPU_LITTLE_ENDIAN),y)
-override flavour := linux-ppc64le
-else
-override flavour := linux-ppc64
-endif
-
-quiet_cmd_perl = PERL $@
- cmd_perl = $(PERL) $(<) $(flavour) > $(@)
+quiet_cmd_perl = PERL $@
+ cmd_perl = $(PERL) $< $(if $(CONFIG_LITTLE_ENDIAN), linux-ppc64le, linux-ppc64) > $@

targets += aesp8-ppc.S ghashp8-ppc.S

-$(obj)/aesp8-ppc.S: $(src)/aesp8-ppc.pl FORCE
- $(call if_changed,perl)
-
-$(obj)/ghashp8-ppc.S: $(src)/ghashp8-ppc.pl FORCE
+$(obj)/aesp8-ppc.S $(obj)/ghashp8-ppc.S: $(obj)/%.S: $(src)/%.pl FORCE
$(call if_changed,perl)
-
-clean-files := aesp8-ppc.S ghashp8-ppc.S
--
2.32.0

2022-05-06 22:56:15

by Masahiro Yamada

Subject: Re: [PATCH] crypto: vmx - Align the short log with Makefile cleanups

Hi Herbert,



On Fri, May 6, 2022 at 7:23 PM Herbert Xu <[email protected]> wrote:
>
> On Sun, May 01, 2022 at 10:07:49PM +0900, Masahiro Yamada wrote:
> > I notieced the log is not properly aligned:
> >
> > PERL drivers/crypto/vmx/aesp8-ppc.S
> > CC [M] fs/xfs/xfs_reflink.o
> > PERL drivers/crypto/vmx/ghashp8-ppc.S
> > CC [M] drivers/crypto/vmx/aes.o
> >
> > Add some spaces after 'PERL'.
> >
> > While I was here, I cleaned up the Makefile:
> >
> > - Merge the two similar rules
> >
> > - Remove redundant 'clean-files' (Having 'targets' is enough)
> >
> > - Move the flavour into the build command
> >
> > This still avoids the build failures fixed by commit 4ee812f6143d
> > ("crypto: vmx - Avoid weird build failures").
> >
> > Signed-off-by: Masahiro Yamada <[email protected]>
> > ---
> >
> > drivers/crypto/vmx/Makefile | 17 +++--------------
> > 1 file changed, 3 insertions(+), 14 deletions(-)
>
> Patch applied. Thanks.


Sorry, I just noticed the 0day bot had reported the error.

I sent v2. (CONFIG_LITTLE_ENDIAN --> CONFIG_CPU_LITTLE_ENDIAN)

https://lore.kernel.org/lkml/[email protected]/


Could you replace it, or fix it up, please?





--
Best Regards
Masahiro Yamada

2022-05-08 19:12:52

by Herbert Xu

Subject: Re: [PATCH] crypto: vmx - Align the short log with Makefile cleanups

On Sun, May 01, 2022 at 10:07:49PM +0900, Masahiro Yamada wrote:
> I notieced the log is not properly aligned:
>
> PERL drivers/crypto/vmx/aesp8-ppc.S
> CC [M] fs/xfs/xfs_reflink.o
> PERL drivers/crypto/vmx/ghashp8-ppc.S
> CC [M] drivers/crypto/vmx/aes.o
>
> Add some spaces after 'PERL'.
>
> While I was here, I cleaned up the Makefile:
>
> - Merge the two similar rules
>
> - Remove redundant 'clean-files' (Having 'targets' is enough)
>
> - Move the flavour into the build command
>
> This still avoids the build failures fixed by commit 4ee812f6143d
> ("crypto: vmx - Avoid weird build failures").
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> drivers/crypto/vmx/Makefile | 17 +++--------------
> 1 file changed, 3 insertions(+), 14 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2022-05-08 19:18:20

by Herbert Xu

Subject: Re: [PATCH] crypto: vmx - Align the short log with Makefile cleanups

On Sat, May 07, 2022 at 12:25:32AM +0900, Masahiro Yamada wrote:
>
> Sorry, I just noticed the 0day bot had reported the error.
>
> I sent v2. (CONFIG_LITTLE_ENDIAN --> CONFIG_CPU_LITTLE_ENDIAN)
>
> https://lore.kernel.org/lkml/[email protected]/
>
>
> Could you replace it, or fix it up, please?

Please send me an incremental patch.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt