2022-07-29 10:37:01

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH v2] crypto: ccree - Remove a useless dma_supported() call

On Wed, Jul 20, 2022 at 03:28:44PM +0200, Christophe JAILLET wrote:
> There is no point in calling dma_supported() before calling
> dma_set_coherent_mask(). This function already calls dma_supported() and
> returns an error (-EIO) if it fails.
>
> So remove the superfluous dma_supported() call.
>
> Moreover, setting a larger DMA mask will never fail when setting a smaller
> one will succeed, so the whole "while" loop can be removed as well. (see
> [1])
>
> While at it, fix the name of the function reported in a dev_err().
>
> [1]: https://lore.kernel.org/all/[email protected]/
>
> Suggested-by: Christoph Hellwig <[email protected]>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> drivers/crypto/ccree/cc_driver.c | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt