2022-09-24 11:36:57

by Weili Qian

Subject: [PATCH] crypto: hisilicon/qm - re-enable communicate interrupt before notifying PF

After the device is reset, the VF needs to re-enable communication
interrupt before the VF sends restart complete message to the PF.
If the interrupt is re-enabled after the VF notifies the PF, the PF
may fail to send messages to the VF after receiving VF's restart
complete message.

Fixes: 760fe22cf5e9 ("crypto: hisilicon/qm - update reset flow")
Signed-off-by: Weili Qian <[email protected]>
---
drivers/crypto/hisilicon/qm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index 8b387de69d22..8b5218686b9e 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -5725,6 +5725,7 @@ static void qm_pf_reset_vf_done(struct hisi_qm *qm)
cmd = QM_VF_START_FAIL;
}

+ qm_cmd_init(qm);
ret = qm_ping_pf(qm, cmd);
if (ret)
dev_warn(&pdev->dev, "PF responds timeout in reset done!\n");
@@ -5786,7 +5787,6 @@ static void qm_pf_reset_vf_process(struct hisi_qm *qm,
goto err_get_status;

qm_pf_reset_vf_done(qm);
- qm_cmd_init(qm);

dev_info(dev, "device reset done.\n");

--
2.33.0

2022-10-21 11:36:57

by Herbert Xu

Subject: Re: [PATCH] crypto: hisilicon/qm - re-enable communicate interrupt before notifying PF

On Sat, Sep 24, 2022 at 07:04:31PM +0800, Weili Qian wrote:
> After the device is reset, the VF needs to re-enable communication
> interrupt before the VF sends restart complete message to the PF.
> If the interrupt is re-enabled after the VF notifies the PF, the PF
> may fail to send messages to the VF after receiving VF's restart
> complete message.
>
> Fixes: 760fe22cf5e9 ("crypto: hisilicon/qm - update reset flow")
> Signed-off-by: Weili Qian <[email protected]>
> ---
> drivers/crypto/hisilicon/qm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt