2022-09-26 09:22:24

by Tianjia Zhang

Subject: [PATCH] crypto: ccm - use local variables instead of indirect references

The variable odata has been introduced into the function scope as
a variable and should be used directly.

Signed-off-by: Tianjia Zhang <[email protected]>
---
crypto/ccm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/ccm.c b/crypto/ccm.c
index 6b815ece51c6..30dbae72728f 100644
--- a/crypto/ccm.c
+++ b/crypto/ccm.c
@@ -218,7 +218,7 @@ static int crypto_ccm_auth(struct aead_request *req, struct scatterlist *plain,
cryptlen += ilen;
}

- ahash_request_set_crypt(ahreq, plain, pctx->odata, cryptlen);
+ ahash_request_set_crypt(ahreq, plain, odata, cryptlen);
err = crypto_ahash_finup(ahreq);
out:
return err;
--
2.24.3 (Apple Git-128)

2022-10-21 11:37:41

by Herbert Xu

Subject: Re: [PATCH] crypto: ccm - use local variables instead of indirect references

On Mon, Sep 26, 2022 at 05:14:21PM +0800, Tianjia Zhang wrote:
> The variable odata has been introduced into the function scope as
> a variable and should be used directly.
>
> Signed-off-by: Tianjia Zhang <[email protected]>
> ---
> crypto/ccm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt