2022-09-27 13:56:56

by Yuan Can

[permalink] [raw]
Subject: [PATCH] crypto: ccp - Remove unused struct ccp_crypto_cpu

After commit bc3854476f36("crypto: ccp - Use a single queue for proper ordering
of tfm requests"), no one use struct ccp_crypto_cpu, so remove it.

Signed-off-by: Yuan Can <[email protected]>
---
drivers/crypto/ccp/ccp-crypto-main.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/drivers/crypto/ccp/ccp-crypto-main.c b/drivers/crypto/ccp/ccp-crypto-main.c
index 5976530c00a8..c8f3345c66e2 100644
--- a/drivers/crypto/ccp/ccp-crypto-main.c
+++ b/drivers/crypto/ccp/ccp-crypto-main.c
@@ -78,13 +78,6 @@ struct ccp_crypto_cmd {
int ret;
};

-struct ccp_crypto_cpu {
- struct work_struct work;
- struct completion completion;
- struct ccp_crypto_cmd *crypto_cmd;
- int err;
-};
-
static inline bool ccp_crypto_success(int err)
{
if (err && (err != -EINPROGRESS) && (err != -EBUSY))
--
2.17.1


2022-09-27 16:00:19

by John Allen

[permalink] [raw]
Subject: Re: [PATCH] crypto: ccp - Remove unused struct ccp_crypto_cpu

On 9/27/22 8:39 AM, Yuan Can wrote:
> After commit bc3854476f36("crypto: ccp - Use a single queue for proper ordering
> of tfm requests"), no one use struct ccp_crypto_cpu, so remove it.
>
> Signed-off-by: Yuan Can <[email protected]>

Acked-by: John Allen <[email protected]>

> ---
> drivers/crypto/ccp/ccp-crypto-main.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/crypto/ccp/ccp-crypto-main.c b/drivers/crypto/ccp/ccp-crypto-main.c
> index 5976530c00a8..c8f3345c66e2 100644
> --- a/drivers/crypto/ccp/ccp-crypto-main.c
> +++ b/drivers/crypto/ccp/ccp-crypto-main.c
> @@ -78,13 +78,6 @@ struct ccp_crypto_cmd {
> int ret;
> };
>
> -struct ccp_crypto_cpu {
> - struct work_struct work;
> - struct completion completion;
> - struct ccp_crypto_cmd *crypto_cmd;
> - int err;
> -};
> -
> static inline bool ccp_crypto_success(int err)
> {
> if (err && (err != -EINPROGRESS) && (err != -EBUSY))

2022-10-21 11:40:34

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] crypto: ccp - Remove unused struct ccp_crypto_cpu

On Tue, Sep 27, 2022 at 01:39:55PM +0000, Yuan Can wrote:
> After commit bc3854476f36("crypto: ccp - Use a single queue for proper ordering
> of tfm requests"), no one use struct ccp_crypto_cpu, so remove it.
>
> Signed-off-by: Yuan Can <[email protected]>
> ---
> drivers/crypto/ccp/ccp-crypto-main.c | 7 -------
> 1 file changed, 7 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt